Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix as_remote conditions" #22

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

crisdut
Copy link
Member

@crisdut crisdut commented Jan 18, 2023

Hi @dr-orlovsky,

After check the problem with CI (#20), I noticed this commit generated a bug.

We need revert the commit. Sorry about that.

Reverts #19
Closes #20

@codecov-commenter
Copy link

Codecov Report

Merging #22 (9b48982) into master (3cde223) will increase coverage by 0.1%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master     #22     +/-   ##
========================================
+ Coverage    35.0%   35.1%   +0.1%     
========================================
  Files          17      17             
  Lines        1848    1841      -7     
========================================
  Hits          647     647             
+ Misses       1201    1194      -7     
Impacted Files Coverage Δ
lnp2p/src/bolt/bolt4.rs 0.0% <0.0%> (ø)
lnp2p/src/bolt/bolt7.rs 0.0% <0.0%> (ø)
lnp2p/src/bifrost/msg.rs 0.0% <0.0%> (ø)
lnp2p/src/bifrost/channel.rs 0.0% <0.0%> (ø)
lnp2p/src/bifrost/proposals.rs 0.0% <0.0%> (ø)
lnp2p/src/bolt/mod.rs 52.9% <0.0%> (+0.8%) ⬆️
lnp2p/src/bifrost/ctrl.rs 31.2% <0.0%> (+0.9%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dr-orlovsky
Copy link
Contributor

  1. Sorry for missing that myself
  2. I do not get why sometimes CI on PRs are running (like now) and sometimes it is not (like on the previous PR, why we missed that bug)

Copy link
Contributor

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 9b48982

@dr-orlovsky dr-orlovsky merged commit 0063e2c into LNP-WG:master Jan 18, 2023
@crisdut crisdut deleted the revert-19-fix/as_remote branch January 26, 2023 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests are broken by #19
3 participants