Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

"Object has been destroyed" Javascript Error when quitting app on windows #677

Closed
mrfelton opened this issue Aug 16, 2018 · 0 comments · Fixed by #679
Closed

"Object has been destroyed" Javascript Error when quitting app on windows #677

mrfelton opened this issue Aug 16, 2018 · 0 comments · Fixed by #679
Assignees
@mrfelton
Labels
scope: windows issues that affect the app on Windows type: bug 🐛 Something isn't working
Milestone
v0.2.2-beta

Comments

@mrfelton
Copy link
Member

Windows users have reported seeing an "Object has been destroyed" javascript error when quitting the app.

img_20180815_182337
@mrfelton mrfelton added type: bug 🐛 Something isn't working scope: windows issues that affect the app on Windows labels Aug 16, 2018
@mrfelton mrfelton added this to the v0.2.2-beta milestone Aug 16, 2018
@mrfelton mrfelton self-assigned this Aug 16, 2018
mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Aug 16, 2018
@mrfelton
fix(grpc): ensure full disconnect on window close
114151f 
Do not try to send incoming data from GRPC streams to the main window
after the window has been closed.

Fix LN-Zap#677
@mrfelton mrfelton mentioned this issue Aug 16, 2018
Merged
6 tasks
mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Aug 20, 2018
@mrfelton
fix(grpc): ensure full disconnect on window close
d6f8c00 
Do not try to send incoming data from GRPC streams to the main window
after the window has been closed.

Fix LN-Zap#677
@mrfelton mrfelton mentioned this issue Dec 9, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mrfelton mrfelton

Labels
scope: windows issues that affect the app on Windows type: bug 🐛 Something isn't working
Projects
None yet
Milestone
v0.2.2-beta
Development

Successfully merging a pull request may close this issue.

fix(grpc): ensure full disconnect on window close mrfelton/zap-desktop
1 participant
@mrfelton