Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Limits on channel balances when opening a new channel should respect the selected default currency #523

Closed
mrfelton opened this issue Jun 30, 2018 · 0 comments
Closed

Limits on channel balances when opening a new channel should respect the selected default currency #523

mrfelton opened this issue Jun 30, 2018 · 0 comments
Labels
type: bug 🐛 Something isn't working
Milestone
v0.2.1-beta

Comments

@mrfelton
Copy link
Member

Some feedback from Slack:

Opening a channel throws an error if the amount is to big. It seems the value is just compared with the number typed in. If you set your default currency unit to satoshi, you won't be able to open the channel as everything larger than 0.17 sathoshi is considered too large
-- @michaelWuensch
@mrfelton mrfelton added the type: bug 🐛 Something isn't working label Jul 11, 2018
@mrfelton mrfelton added this to the v0.2.1 milestone Jul 25, 2018
mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Jul 25, 2018
@mrfelton
fix: honour currency when opening channel
8220ed0 
Ensure that the currently active unit of account is honoured when
opening a new channel.

Fix LN-Zap#523
Also see LN-Zap#604
@mrfelton mrfelton mentioned this issue Jul 25, 2018
Merged
mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Jul 26, 2018
@mrfelton
fix: honour currency when opening channel
3627275 
Ensure that the currently active unit of account is honoured when
opening a new channel.

Fix LN-Zap#523
Also see LN-Zap#604
@mrfelton mrfelton mentioned this issue Jul 30, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: bug 🐛 Something isn't working
Projects
None yet
Milestone
v0.2.1-beta
Development

No branches or pull requests
1 participant
@mrfelton