Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Don't disable pay form if no routes are found #1048

Closed
JimmyMow opened this issue Dec 8, 2018 · 1 comment
Closed

Don't disable pay form if no routes are found #1048

JimmyMow opened this issue Dec 8, 2018 · 1 comment
Assignees
@mrfelton
Labels
branch: next type: enhancement New feature or request
Milestone
v0.3.0-beta

Comments

@JimmyMow
Copy link
Member

JimmyMow commented Dec 8, 2018

Right now we disable the pay form if we can't find any routes. The issue with the is lnd doesn't yet support private channels in queryRoutes/sendToRoute so if a user is trying to send to an invoice with hop hints Zap will not allow them to send.

We should still allow the user to attempt to send even if we don't find any routes.
@JimmyMow JimmyMow added this to the v0.3.0-beta milestone Dec 8, 2018
mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Dec 9, 2018
@mrfelton
fix(pay): allow sending without route info
d591b1d 
Do not disable the pay form submit button if we were unable to find a
route. This is a hack to work around the fact that queryroutes doesn't
currently support private channels yet we do want to allow sending
along private channels.

Fix LN-Zap#1048
@mrfelton mrfelton mentioned this issue Dec 9, 2018
Merged
6 tasks
mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Dec 10, 2018
@mrfelton
fix(pay): allow sending without route info
6469c10 
Do not disable the pay form submit button if we were unable to find a
route. This is a hack to work around the fact that queryroutes doesn't
currently support private channels yet we do want to allow sending
along private channels.

Fix LN-Zap#1048
@JimmyMow
Copy link
Member Author

closing with #1056 merged

mrfelton added a commit that referenced this issue Dec 12, 2018
@mrfelton
fix(pay): allow sending without route info
ffc571b 
Do not disable the pay form submit button if we were unable to find a
route. This is a hack to work around the fact that queryroutes doesn't
currently support private channels yet we do want to allow sending
along private channels.

Fix #1048
mrfelton added a commit that referenced this issue Dec 12, 2018
@mrfelton
fix(pay): allow sending without route info
5d62ee5 
Do not disable the pay form submit button if we were unable to find a
route. This is a hack to work around the fact that queryroutes doesn't
currently support private channels yet we do want to allow sending
along private channels.

Fix #1048
mrfelton added a commit that referenced this issue Dec 15, 2018
@mrfelton
fix(pay): allow sending without route info
9807dec 
Do not disable the pay form submit button if we were unable to find a
route. This is a hack to work around the fact that queryroutes doesn't
currently support private channels yet we do want to allow sending
along private channels.

Fix #1048
@mrfelton mrfelton added type: enhancement New feature or request and removed type: enhancement labels Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mrfelton mrfelton

Labels
branch: next type: enhancement New feature or request
Projects
None yet
Milestone
v0.3.0-beta
Development

No branches or pull requests
2 participants
@mrfelton @JimmyMow