Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make PluginView::isResizable a virtual #7541

Merged
merged 1 commit into from
Oct 12, 2024
Merged

Make PluginView::isResizable a virtual #7541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions include/PluginView.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,7 @@ class LMMS_EXPORT PluginView : public QWidget, public ModelView
{
}

void setResizable(bool resizable) { m_isResizable = resizable; }
bool isResizable() { return m_isResizable; }

private:
bool m_isResizable = false;
virtual bool isResizable() const { return false; }
};

} // namespace lmms::gui
Expand Down
1 change: 0 additions & 1 deletion plugins/SlicerT/SlicerTView.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ SlicerTView::SlicerTView(SlicerT* instrument, QWidget* parent)

setMaximumSize(QSize(10000, 10000));
setMinimumSize(QSize(516, 400));
setResizable(true);

m_wf = new SlicerTWaveform(248, 128, instrument, this);
m_wf->move(0, s_topBarHeight);
Expand Down
2 changes: 2 additions & 0 deletions plugins/SlicerT/SlicerTView.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,8 @@ public slots:
void resizeEvent(QResizeEvent* event) override;

private:
bool isResizable() const override { return true; }

SlicerT* m_slicerTParent;

Knob* m_noteThresholdKnob;
Expand Down
Loading