Make the send button and receive arrow occupy the same space #7503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Rossmaxx <74815851+Rossmaxx@users.noreply.github.com>
|
@Rossmaxx, do you notice any problem with rendering the effects in this PR? |
* Update SlicerT UI * Style review Co-authored-by: Rossmaxx <74815851+Rossmaxx@users.noreply.github.com> * Style fixes --------- Co-authored-by: Rossmaxx <74815851+Rossmaxx@users.noreply.github.com>
Remove all content margins and spacing between child widgets for each mixer channel strip.
Didn't check this PR but on latest master, there's a glitch. I didn't have this glitch on previous master, which was 9 commits behind. The only sus change seems to be #7502. I'll do something and check. Update: seems like something else is at play. I'm looking. |
…-button-or-receive-arrow
…-button-or-receive-arrow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for another unintended change in #6591. Before, the send button and the receive arrow in the mixer channel view occupied the same space (i.e., either the send button was shown, or the receive arrow, without using two designated spots in the mixer channel for the two widgets, but one).
Here is a before and after. The difference is subtle, but notice how the receive arrow at the top was moved down a bit. This is because it is now occupying the same space the send button is occupying.
Before:
After:
