Support VSTs on Linux even if Wine is unavailable #7205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if I'm missing it, but it looks like Vestige isn't being built in any of the jobs? I don't find it in the build log, only VstBase. |
|
It shows up for me when searching, for all jobs except macOS, where we don't support VSTs. Make sure to expand the "Build" section, and use GitHub's search box instead of your browser's (not all log lines are present on the page at once, presumably to reduce resource usage). |
|
Ah, found it now. Weird that browser search wouldn't find it, it usually does. |
Veratil
approved these changes
Apr 13, 2024
messmerd
approved these changes
Apr 14, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now separately check support for the 32-bit Windows host, 64-bit Windows host, and the native Linux host, and enable VST support if any of the hosts are available. We still check for Windows VST support by default, but this can be turned off through CMake options, and won't disable VST support even if it fails.
Fixes #7148.