CI: Unpack installers, test --help and --version

[JohannesLorenz]

Finally ready to review. Thanks to the almost not countable devs who helped.

For discussion:

• Time spent Most systems are equally fast, however, MinGW takes ~ 1 minute more (master average time is 9 minutes), because I added dpkg --add-architecture i386 && apt-get --yes update. I also had to add a second apt-get install, which however just takes ~ 15 seconds. I hope that is all acceptable.

[Veratil]

Feel free to ignore these if you want, but some of the formatting I feel is completely unnecessary and adding extra lines for no reason.

[JohannesLorenz]

@DomClark as a friendly reminder, it seems like you self-requested a review here last month.

[DomClark]

I don't think build.yml is the right place to define end-to-end tests. It means they have to be defined multiple times (for Linux, macOS, MinGW, and MSVC jobs), and they will quickly clutter the file (which is intended to define the build process instead) if many more are added. I don't mind launching the tests from there (as we do for the current suite), but I think a separate script would be more appropriate to define them.

[DomClark]

There are three things changed in this PR:

• The memory leak fix for the help/version commands. This looks good to me.
• The end-to-end tests for said commands. I still think the build action is the wrong place to define these, especially as separate steps. While end-to-end tests are worth having, I'd rather leave them out for now, and find a proper way to write them. (This could even be done in a separate action, which would enable us to test the MinGW builds in a real Windows environment, rather than under Wine.)
• The introduction of yamllint. This also looks good to me, but is only relevant in the context of the build script changes, so I'd make it a separate PR.

[Rossmaxx]

Since this PR has been spun up into #7424 and #7423 , better to close this PR in favour of it's children.

[JohannesLorenz]

Thanks, but since this contains multiple open comments from Dom, I will rather keep using this for the remaining CI commit. I will fix the title and description.

[JohannesLorenz]

Oh no now it cannot be reopened :-( OK, I will open a new PR...

[JohannesLorenz]

• While end-to-end tests are worth having, I'd rather leave them out for now, and find a proper way to write them. (This could even be done in a separate action, which would enable us to test the MinGW builds in a real Windows environment, rather than under Wine.)

Do you mean having 2 actions in sequential order, e.g. let one action use jobs.JOBID.needs?