Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found an oddity caused by the Random function. Fixed up some older oddities and glitches at the same time.
noerratic action. The value needed updating.The change on the Vibrato is how you expect the knobs to work. On a long note you should hear the vibrato change when you turn the knobs but it was only updated on every new note. There is no way to create an upgrade routine for this but the effect should be subtle and not cause any problems. Same with the ADSR. The knob didn't have an effect previously but if it was turned, with no perceived effect, the new value was still saved with the project correctly so in this case older projects may not upgrade properly. This will also be subtle changes where the ADSR knob modulates the action of the Modulator and Crossfade knobs. You could probably dig into the STK code here but I don't think it's going to be worth the effort. Been there, done that.
The ModalBar Vibrato and stick mix control messages in stk seem to have been mixed up. Reported upstream.
thestk/stk#143