Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mallets - Some small fixes #6913

Merged
merged 6 commits into from
Oct 6, 2023
Merged

Mallets - Some small fixes #6913

merged 6 commits into from
Oct 6, 2023

Conversation

zonkmachine
Copy link
Member

@zonkmachine zonkmachine commented Oct 1, 2023

Found an oddity caused by the Random function. Fixed up some older oddities and glitches at the same time.

  • Fix an issue with the Random algorithm where the randomized variables ended up half as big as they should be.
  • Tubular Bells
    • Implement the ADSR knob which had no erratic action. The value needed updating.
    • LFO - update values while playing.
  • BandedWG (Uniform Bar, Tuned Bar, etc.) - Randomize values of Pressure and Speed.
  • ModalBar (Marimba, Vibraphone, etc.) - Update values of Vibrato (Gain, Frequency) while playing.

The change on the Vibrato is how you expect the knobs to work. On a long note you should hear the vibrato change when you turn the knobs but it was only updated on every new note. There is no way to create an upgrade routine for this but the effect should be subtle and not cause any problems. Same with the ADSR. The knob didn't have an effect previously but if it was turned, with no perceived effect, the new value was still saved with the project correctly so in this case older projects may not upgrade properly. This will also be subtle changes where the ADSR knob modulates the action of the Modulator and Crossfade knobs. You could probably dig into the STK code here but I don't think it's going to be worth the effort. Been there, done that.

The ModalBar Vibrato and stick mix control messages in stk seem to have been mixed up. Reported upstream.
thestk/stk#143

plugins/Stk/Mallets/Mallets.cpp Outdated Show resolved Hide resolved
@zonkmachine
Copy link
Member Author

I had a bit of a struggle with the code to update values for the Vibrato in the ModalBar (Marimba - Clump). There seem to be an issue in stk where the control values have been mixed up so when I tried to update the vibrato the direct stick mix got turned up instead...

@zonkmachine
Copy link
Member Author

I believe this is ready to merge. Please note that we intentionally use the wrong control value for Vibrato Frequency but this is nothing new. The control messages for Vibrato Frequency and Stick Mix are already the wrong values in Mallets and this is due to an upstream issue.

@DomClark DomClark merged commit 42c5101 into LMMS:master Oct 6, 2023
9 checks passed
@zonkmachine zonkmachine deleted the malletfixup branch October 6, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants