Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant nameChanged signal from InstrumentTrack #6742

Merged
merged 1 commit into from
Jul 2, 2023
Merged

Remove redundant nameChanged signal from InstrumentTrack #6742

merged 1 commit into from
Jul 2, 2023

Conversation

Veratil
Copy link
Contributor

@Veratil Veratil commented Jun 22, 2023

Noticed a bunch of these messages:

QMetaObject::indexOfSignal: signal nameChanged() from lmms::Track redefined in lmms::InstrumentTrack

This removes the signal from InstrumentTrack since it gets it from inheritance (InstrumentTrack : public Track and nameChanged is in public scope).

Also, since Track::setName emits nameChanged this removes a second emit of the same signal.

@superpaik
Copy link
Contributor

Tested ok on win10/64b

@PhysSong PhysSong merged commit 5ccc8d9 into LMMS:master Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superpaik superpaik superpaik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Veratil @superpaik @PhysSong