-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix include guards and copyright statements #6603
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
My only note is a few of the #endif
's lost their // GUARD_H
comment. We don't really need them since they're EOF, but it doesn't hurt to have I think?
There were only a few instances of those, so I just removed them for consistency with the rest of the headers. |
Actually, I'll go ahead and add them to all the headers. It would be better to have them, and now's the best time to do it. |
Generally looks good. |
This PR corrects some minor issues with header files under
include/
LMMS_
orLMMS_GUI_
) to include guards of header files in theinclude/
directory. This fixes a name conflict between the include guards ofinclude/Engine.h
andplugins/ZynAddSubFx/zynaddsubfx/src/Nio/Engine.h
and possibly others. It will also prevent any future conflicts.Clip.h
andClipView.h
were still using their old "track content object" names from before the reorganization. This has been corrected. (#5592)MidiCCRackView.h
.CustomTextKnob.h
andCustomTextKnob.cpp
according to author's comment in #5321.