Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recording not possible with MIDI keyboard in PianoRoll #6593

Merged
merged 1 commit into from
Jan 1, 2023

Conversation

localhost-127
Copy link
Contributor

closes #6592
Just Added missing namespace for Note .
Now Recording works as before.

@PhysSong
Copy link
Member

Thank you for your contribution! Maybe out of scope, but I found one more similar bug: in plugins/AudioFileProcessor/AudioFileProcessor.cpp, f_cnt_t type is missing the lmms namespace as well.

@localhost-127
Copy link
Contributor Author

Thank you for your contribution! Maybe out of scope, but I found one more similar bug: in plugins/AudioFileProcessor/AudioFileProcessor.cpp, f_cnt_t type is missing the lmms namespace as well.

Thanks for letting me know about this bug.
Do you know if this missing lmms namespace qualifier for f_cnt_t is breaking anything in AudioFileProcessor?

@PhysSong
Copy link
Member

Do you know if this missing lmms namespace qualifier for f_cnt_t is breaking anything in AudioFileProcessor?

It breaks "Display playback cursor in AudioFileProcessor" feature.

@PhysSong PhysSong changed the title Fix: Recording not possible with Midi keyboard in PianoRoll Fix recording not possible with MIDI keyboard in PianoRoll Jan 1, 2023
@PhysSong PhysSong merged commit 2f28c2b into LMMS:master Jan 1, 2023
sakertooth pushed a commit to sakertooth/lmms that referenced this pull request May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recording with Midi Keyboard not working
3 participants