Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ZynAddSubFx with MSVC #6561

Merged
merged 7 commits into from
Jan 2, 2023
Merged

Support ZynAddSubFx with MSVC #6561

merged 7 commits into from
Jan 2, 2023

Conversation

DomClark
Copy link
Member

@DomClark DomClark commented Nov 4, 2022

@DomClark DomClark mentioned this pull request Nov 4, 2022
Merged
@DomClark
Merge remote-tracking branch 'upstream/master' into zyn-msvc
e1d478f
@DomClark
Fix tests
07285be 
* Add `ThreadShims.h` to exclude list.
* Fix `check-namespace` to work correctly on Windows.
@DomClark
Use spaces for indentation in Python code
0383c50
@DomClark DomClark merged commit d95c897 into LMMS:master Jan 2, 2023
@DomClark DomClark deleted the zyn-msvc branch January 2, 2023 23:42
@PhysSong PhysSong mentioned this pull request Jan 2, 2023
Open
15 tasks
sakertooth pushed a commit to sakertooth/lmms that referenced this pull request Jan 6, 2023
@DomClark @sakertooth
Support ZynAddSubFx with MSVC (LMMS#6561)
0a79887
@tresf
Copy link
Member

tresf commented May 6, 2023

Testing #6700, this PR breaks compiling on MacOS. Revertign d95c897 allows builds to succeed again so testing can commence.

@tresf tresf mentioned this pull request May 6, 2023
Closed
sakertooth pushed a commit to sakertooth/lmms that referenced this pull request May 30, 2023
@DomClark @sakertooth
Support ZynAddSubFx with MSVC (LMMS#6561)
c67d8ca
sakertooth pushed a commit to sakertooth/lmms that referenced this pull request May 30, 2023
@DomClark @sakertooth
Support ZynAddSubFx with MSVC (LMMS#6561)
7148160
@PhysSong PhysSong mentioned this pull request Jul 27, 2023
Closed
@DomClark DomClark mentioned this pull request Apr 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhysSong PhysSong PhysSong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DomClark @tresf @PhysSong