-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Phaser effect to LMMS #6540
base: master
Are you sure you want to change the base?
Conversation
As per the UI, I am lead to believe AMNT is for amount. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know absolutely nothing about filters and such, and I haven't studied the calculations. The UI is sleek even if I don't understand what all the knobs does. This probably calls for some gitbook documentation later... All I can look at is general coding style and it looks very good. Just left a few remarks.
plugins/Phaser/CMakeLists.txt
Outdated
@@ -0,0 +1,3 @@ | |||
INCLUDE(BuildPlugin) | |||
|
|||
BUILD_PLUGIN(Phaser PhaserEffect.cpp PhaserControls.cpp PhaserControlDialog.cpp MOCFILES PhaserEffect.h PhaserControls.h PhaserControlDialog.h ../Eq/EqFader.h EMBEDDED_RESOURCES "${CMAKE_CURRENT_SOURCE_DIR}/*.png") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since EqFader.h
is reused here it would be a good candidate to move to src/gui/widgets
how do i download this plugin? |
You need to build it from source. (edit: probably) |
How do I do that? |
If you're on a linux machine, this is not particularly hard. For future help on compiling this PR, please join and use our Discord https://discord.com/invite/3sc5su7 group. |
Oopsie! |
Replaces #5168, companion PR to #5873. I already listed most of the features in the initial post, so I won't bother here.
I've fixed the bitrot issues that built up over time, and also added a few internal improvements (most notably 2x oversampling to every source of distortion). I have no idea how to build a "good" oversampling filter, but for an effect of this nature I don't think absolute perfection is required in this aspect. Just as long as most of the aliasing is removed. I just used two lowpasses each for the input and output, cutoff at exactly Nyquist of the original sample rate.
A screenshot of the UI (thanks to H4CKTON3 for the assistance)
This is a very old video so it's out of date in some aspects, but it provides an easy-access showing of some of its features:
https://www.youtube.com/watch?v=_Zyd7OcZRO8