-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Sf2 Player, Mallets, PortAudio, and Lame with MSVC #6507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rawwaves directory is not yet installed; a more general fix is required to handle MinGW too.
* Remove change log * Remove SDL2main target * Remove debug code * Convert commands to lowercase * Remove arguments from else/endif * Tweak formatting
Only build a single version of ports required by both host and target
PhysSong
reviewed
Sep 13, 2022
PhysSong
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in #6132, this is done by modifying the CMake code to consume these as imported targets, which can come either from vcpkg or from our own find modules. The FluidSynth port in vcpkg doesn't come with CMake support, but I have written a find module that produces an imported target anyway, as this is the preferred modern approach.
Changes:
CMakeLists.txt
to the find module, for consistency with the others. I feel this is better than cluttering the list file with logic related to finding packages, which is the whole point of find modules.CMAKE_NO_SYSTEM_FROM_IMPORTED
for MinGW builds. Some headers of libstdc++ are sensitive to the include search order, which can be changed by specifying system headers. Treating imported target headers as standard includes avoids modifying the order inadvertently.I think this only leaves the LADSPA plugins, ZynAddSubFx, and Gig Player missing from MSVC builds now.