Update .clang-tidy

[JohannesLorenz]

Should we update this file?

Check the two commits separately to understand what I changed.

[irrenhaus3]

modernize-use-default can screw up in some places because it's too eager. I had it happen in a scenario like

Foo():
 m_Member1(A_CONSTANT, ANOTHER_CONSTANT),
 m_Member2(YET_ANOTHER_CONSTANT)
 {}

which it replaced with

Foo():
 m_Member1(A_CONSTANT, ANOTHER_CONSTANT),
 m_Member2(YET_ANOTHER_CONSTANT)
 = default;

which is a syntax error.
If that happens, it needs manual correction or git restore. If we can live with that, LGTM.

[JohannesLorenz]

If that happens, it needs manual correction or git restore. If we can live with that, LGTM.

As we agreed to only use clang-tidy for manual editing of single files (because, as we see here again, clang-tidy is too buggy for automation/CI), I think that's OK. A git restore does not seem necessary, IIRC you can just remove 1 or 2 lines in such a case.

[irrenhaus3]

Aye, if we only run it manually anyway, go ahead and merge. 👍