Correctly upgrade projects saved by LMMS forks #6424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩
Linux
Windows
macOS🤖{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://output.circle-artifacts.com/output/job/46b3b37e-df92-4c65-9af5-a2e921ddae64/artifacts/0/lmms-1.3.0-alpha.1.194+g37081cf99-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/17060?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://output.circle-artifacts.com/output/job/f587ea27-6b07-4c7d-ab38-0bd9ae46e8a9/artifacts/0/lmms-1.3.0-alpha.1.194+g37081cf99-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/17064?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://output.circle-artifacts.com/output/job/8ca808d5-c995-4386-a60e-ed719f217761/artifacts/0/lmms-1.3.0-alpha.1.194+g37081cf99-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/17062?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/ox17hiiqjdxp009m/artifacts/build/lmms-1.3.0-alpha-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/43757858"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/4ksd9q0pa32gkxri/artifacts/build/lmms-1.3.0-alpha-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/43757858"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://output.circle-artifacts.com/output/job/6783d4d2-d4b3-4b29-89e6-2a8d929feab7/artifacts/0/lmms-1.3.0-alpha.1.194+g37081cf99-mac10.14.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/17061?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "3e615de2ac71ca516dde07af733398fded162fb7"} |
|
Tested, fix confirmed! |
DomClark
reviewed
Jun 4, 2022
DomClark
approved these changes
Jun 4, 2022
|
Does this also fix #6414? |
Can you please download a test build (LmmsBot, above) and test this? That would be much appreciated! |
|
I tested it, unfortunately the issue still exists. I guess something else is going on with that one. |
JohannesLorenz
approved these changes
Jun 11, 2022
|
Merge? Or a second real world test? I don't know how you usually do for smaller PRs. |
|
Confirmed fixes the import of demos (not just Okay to merge from me. |
sakertooth
pushed a commit
to sakertooth/lmms
that referenced
this pull request
May 30, 2023
* Do project file upgrades based on file version and not on LMMS version * Do upgrade after version check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check
version(of file format) instead ofcreatorversion(of LMMS) when deciding if a project file needs to be upgraded.This fixes the currently broken
demos/DnB.mmpz. It got saved by a fork1.3.0-alpha.1.199back in #6239. The current master is at1.3.0-alpha.1.191so - funny enough - it will be automatically un-broken in 9 commits.