Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix changing LcdSpinBox value changing their initial value #6241

Merged
merged 1 commit into from
Dec 25, 2021
Merged

Fix changing LcdSpinBox value changing their initial value #6241

merged 1 commit into from
Dec 25, 2021

Conversation

merrickclay
Copy link
Contributor

This PR aims to fix #6213.
Very simple fix.

@LmmsBot
Copy link

LmmsBot commented Dec 24, 2021

🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩

Linux

Windows

macOS

🤖
{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://15281-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.152%2Bg190b7f1a3-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/15281?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://15283-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.152%2Bg190b7f1a3-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/15283?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://15280-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.152%2Bg190b7f1a3-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/15280?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/pcvqfkixjjjqd21c/artifacts/build/lmms-1.3.0-alpha-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/42002276"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/ap5k9av8vf5ip9wq/artifacts/build/lmms-1.3.0-alpha-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/42002276"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://15284-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.152%2Bg190b7f1a3-mac10.14.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/15284?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "46ddc564e743f2b38f17705ffc441b54209a90fa"}

@PhysSong PhysSong changed the title Fixed issue where changing LcdSpinBox value would change the init value Fix changing LcdSpinBox value changing their initial value Dec 25, 2021
@PhysSong PhysSong merged commit f825825 into LMMS:master Dec 25, 2021
gityssh pushed a commit to gityssh/lmms that referenced this pull request Dec 25, 2021
Fix changing LcdSpinBox value changing their init value (LMMS#6241)
@spechtstatt
Copy link
Contributor

Great that this is fixed!

@merrickclay merrickclay deleted the lcdspinbox_fixInit branch December 29, 2021 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mouse operations on LcdSpinBox modify "reset" value
4 participants