Namespace lmms

[irrenhaus3]

This PR places all LMMS symbols into namespaces to eliminate any potential future name collisions between LMMS and third-party modules.

Work in progress; See #6086 for discussion.

[irrenhaus3]

All requests in the second clazy-related comment addressed; In the mentioned files, all overriding functions (including non-empty destructors) have been marked override, empty destructors have been removed since the compiler default-generates them, and the unused private member in Lv2ViewBase has been removed.

[JohannesLorenz]

IIRC, you forgot those:

include/InstrumentTrack.h:240:2: warning: signal arguments need to be fully-qualified (const lmms::Note instead of const Note) [-Wclazy-fully-qualified-moc-types]
        void midiNoteOn( const Note& );
        ^
include/InstrumentTrack.h:241:2: warning: signal arguments need to be fully-qualified (const lmms::Note instead of const Note) [-Wclazy-fully-qualified-moc-types]
        void midiNoteOff( const Note& );
        
include/SampleBuffer.h:287:2: warning: slot arguments need to be fully-qualified (const lmms::f_cnt_t instead of const f_cnt_t) [-Wclazy-fully-qualified-moc-types]
        void setStartFrame(const f_cnt_t s);
        ^
include/SampleBuffer.h:288:2: warning: slot arguments need to be fully-qualified (const lmms::f_cnt_t instead of const f_cnt_t) [-Wclazy-fully-qualified-moc-types]
        void setEndFrame(const f_cnt_t e);

include/SampleBuffer.h:287:2: warning: slot arguments need to be fully-qualified (const lmms::f_cnt_t instead of const f_cnt_t) [-Wclazy-fully-qualified-moc-types]
        void setStartFrame(const f_cnt_t s);
        ^
include/SampleBuffer.h:288:2: warning: slot arguments need to be fully-qualified (const lmms::f_cnt_t instead of const f_cnt_t) [-Wclazy-fully-qualified-moc-types]
        void setEndFrame(const f_cnt_t e);

After that, I can approve the code.

[irrenhaus3]

The clazy run from within my IDE missed these for some reason. Here you go. :)

[JohannesLorenz]

Sorry, copy&paste error from my side. 2 more:

plugins/AudioFileProcessor/AudioFileProcessor.h:97:2: warning: signal arguments need to be fully-qualified (lmms::f_cnt_t instead of f_cnt_t) [-Wclazy-fully-qualified-moc-types]
        void isPlaying( f_cnt_t _current_frame );
        ^
plugins/AudioFileProcessor/AudioFileProcessor.h:238:2: warning: slot arguments need to be fully-qualified (lmms::f_cnt_t instead of f_cnt_t) [-Wclazy-fully-qualified-moc-types]
        void isPlaying( f_cnt_t _current_frame );
        ^

[irrenhaus3]

Yup, looks like my IDE is acting up there. It marks this one in a tooltip, but running the inspection action on the file doesn't find it. Whyyyyy.
Anyway, here you go again. ^^

[irrenhaus3]

Program is displaying runtime errors now. Turns out, you need to fully qualify the signals in their connect-statements, too, or Qt doesn't know what you're talking about. Gonna fix these next.

[JohannesLorenz]

Yeah, there were a lot more warnings with signals/slots overriding each other. Let me know if you need the whole log. Also, I posted 2 issues in that file and you only fixed one 😁

[JohannesLorenz]

Code looks good. All comments solved. The PR does not introduce new clazy issues.

I did some basic testing (the 5 track types, load/save, playing something in zyn), it all worked. Themes are working, too.