Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Carla automation #5846

Merged
merged 21 commits into from
Jun 30, 2021
Merged

Feature: Carla automation #5846

merged 21 commits into from
Jun 30, 2021

Commits on Apr 11, 2021

  1. Updated work on Carla parameters to latest LMMS master branch.

    CYBERDEViL committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    21b5478 View commit details
    Browse the repository at this point in the history

  2. Update Carla UI after a knob changed from LMMS

    CYBERDEViL committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    1e29794 View commit details
    Browse the repository at this point in the history

  3. Grow/shrink layout when the params subwindow changes width.

    CYBERDEViL committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    4adf8a5 View commit details
    Browse the repository at this point in the history

  4. Fix crash on delete last plugin from carla (no params left).

    CYBERDEViL committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    9d9cfe4 View commit details
    Browse the repository at this point in the history

  5. - Display Carla params correctly on first show. 

    - Removed unused function modelChanged().
    CYBERDEViL committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    ab851c4 View commit details
    Browse the repository at this point in the history

  6. Prevent posible division by zero.

    CYBERDEViL committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    4a26a08 View commit details
    Browse the repository at this point in the history

  7. Move GUI stuff from CarlaInstrument to CarlaInstrumentView. Rename NU… 

    …LL to nullptr. Removed unnescerarry check.
    CYBERDEViL committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    8a0f209 View commit details
    Browse the repository at this point in the history

  8. Some better naming.

    CYBERDEViL committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    df3f7d9 View commit details
    Browse the repository at this point in the history

  9. Style: honor max line length of 120 characters.

    CYBERDEViL committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    6f283b4 View commit details
    Browse the repository at this point in the history

  10. Remove some whitespaces and adjusted comment.

    CYBERDEViL committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    9cd5cf0 View commit details
    Browse the repository at this point in the history

  11. Remove debug code.

    CYBERDEViL committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    f5fcb27 View commit details
    Browse the repository at this point in the history

  12. Fix fatal typo

    CYBERDEViL committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    305bc02 View commit details
    Browse the repository at this point in the history

  13. Address some minor [naming] coding conventions issues.

    CYBERDEViL committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    fececb5 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2021

  1. Remove the +1, it was left-over from experimenting.

    CYBERDEViL committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    73d9e26 View commit details
    Browse the repository at this point in the history

  2. Fix the calculation of how many knobs will fit in a row. 

     + Renamed 'maxWidth' to 'maxKnobWidth' 'cause that's what it is.
    CYBERDEViL committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    25fb33b View commit details
    Browse the repository at this point in the history

  3. Make sure param models are deleted in instrument destructor.

    CYBERDEViL committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    c17494b View commit details
    Browse the repository at this point in the history

  4. Renaming of some methods and members from *knob* to *param* for consi… 

    …stency.

Methods:
 - CarlaInstrument::clearKnobModels() to CarlaInstrument::clearParamModels()
 - CarlaInstrument::knobModelChanged() to CarlaInstrument::paramModelChanged()
 - CarlaInstrument::updateKnobModel() to CarlaInstrument::updateParamModel()

Members:
 - m_knobGroupCount to m_paramGroupCount
    CYBERDEViL committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    ac6b42e View commit details
    Browse the repository at this point in the history

  5. Forgot to add carla.h in the previous commit.

    CYBERDEViL committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    2ff65b2 View commit details
    Browse the repository at this point in the history

  6. Code style blocking.

    CYBERDEViL committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    a2c6d95 View commit details
    Browse the repository at this point in the history

  7. Code style pointers

    CYBERDEViL committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    49e91a3 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2021

  1. Fix lambda capture after review

    @JohannesLorenz
    JohannesLorenz committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    ffd4662 View commit details
    Browse the repository at this point in the history