Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: PianoRoll Razor #5845

Merged
merged 14 commits into from
Feb 26, 2021
Merged

Feature: PianoRoll Razor #5845

merged 14 commits into from
Feb 26, 2021

Commits on Dec 9, 2020

  1. Initial PianoRoll razor feature

    CYBERDEViL committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    b8d37e6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    30f2e37 View commit details
    Browse the repository at this point in the history
  3. Show changes directly after cut.

    CYBERDEViL committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    3156065 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ca0ed81 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2021

  1. Extract the split action to a separate method

    	This PR addresses some suggestions from a review, the most
    important ones being:
    	- Extracting the note split action to a separate method, called
    Pattern::splitNotes
    	- Removing getMouseTickPos method
    	- Adding a variable that holds the current razor position and a
    method to update it (quantizing if CTRL is not pressed)
    	- Using [this] to capture "this" on the lambda function instead
    of [=], since the latter doesn't work as intended from C++20 forward
    	- Fixing some code style and adding comments
    IanCaio committed Feb 20, 2021
    Configuration menu
    Copy the full SHA
    20a37ea View commit details
    Browse the repository at this point in the history
  2. Removes an extra call to noteUnderMouse

    	By removing "&& noteUnderMouse()" from the mousePressEvent
    conditional, we avoid an extra call to noteUnderMouse. The only
    difference in the behavior of the tool is that now clicking on a place
    that doesn't have a note will exit Razor mode.
    IanCaio committed Feb 20, 2021
    Configuration menu
    Copy the full SHA
    2529604 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2021

  1. Style change suggested by @russiankumar

    CYBERDEViL committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    10efa14 View commit details
    Browse the repository at this point in the history
  2. Cancel razor action on SHIFT release.

    CYBERDEViL committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    219ff68 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2021

  1. Make razor cut-line (color) themable.

    CYBERDEViL committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    e348475 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2021

  1. Add razor cut-line color to classic theme style.css

    CYBERDEViL committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    72de0ea View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2021

  1. Rename razor to knife.

    CYBERDEViL committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    ecdc5ed View commit details
    Browse the repository at this point in the history
  2. Change pixmap from razor to knife (from LMMS#5524)

    CYBERDEViL committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    ac47d37 View commit details
    Browse the repository at this point in the history
  3. Remove SHIFT behavior.

    CYBERDEViL committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    46207dc View commit details
    Browse the repository at this point in the history
  4. Change knife shortcut to SHIFT+K

    CYBERDEViL committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    63bd4f1 View commit details
    Browse the repository at this point in the history