FifoBuffer adjustments #5803
Merged
FifoBuffer adjustments #5803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩
Linux
Windows
macOS🤖{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://11893-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.61%2Bg691d162-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/11893?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://11890-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.61%2Bg691d16276-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/11890?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://11894-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.61%2Bg691d16276-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/11894?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/fyyyd2wfmhxjsld0/artifacts/build/lmms-1.3.0-alpha-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/37054157"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/3u42qlbs3vk6re9u/artifacts/build/lmms-1.3.0-alpha-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/37054157"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://11891-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.61%2Bg691d16276-mac10.14.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/11891?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "c65c5dd4e2f6af05f44b65d22e876d40154cf392"} |
|
I like the updates, but I don't think removing the template is necessary even if we're only using it with a single type. |
|
Rebase done. Should I keep the removed template? If so, this will become just another reformatting PR. |
I think keeping is better for now. |
I think that shouldn't be in a PR which changes |
|
@PhysSong It is just a typo I noticed while preparing this PR. |
|
This should be merged before reorg, so I'm reviewing this now. |
IanCaio
pushed a commit
to IanCaio/lmms
that referenced
this pull request
Mar 28, 2021
devnexen
pushed a commit
to devnexen/lmms
that referenced
this pull request
Apr 10, 2021
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The template in
fifoBufferis unnecessary because only one type is used (surroundSampleFrame *). The PR also fixes the coding conventions for that header file.Additionally, it fixes the typoed method name
Song::setLoadOnLauch().