Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lv2 packages to Mac CI #5532

Merged
merged 3 commits into from
Sep 24, 2020
Merged

Add lv2 packages to Mac CI #5532

merged 3 commits into from
Sep 24, 2020

Conversation

JohannesLorenz
Copy link
Contributor

  • Add lv2 packages to Mac CI
  • When it fails (I hope it will) I'll fix the mac issue

@LmmsBot
Copy link

LmmsBot commented Jun 11, 2020 •
edited
Loading

🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩

Linux

Windows

macOS

🤖 
{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://8945-15778896-gh.circle-artifacts.com/0/lmms-1.2.3-712%2Bg6de03e1-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/8945?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://8944-15778896-gh.circle-artifacts.com/0/lmms-1.2.3-712%2Bg6de03e132-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/8944?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://8946-15778896-gh.circle-artifacts.com/0/lmms-1.2.3-712%2Bg6de03e132-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/8946?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/vaqhld5rbstly6b2/artifacts/build/lmms-1.2.2-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/35378884"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/l5aaneo0a9iar7qs/artifacts/build/lmms-1.2.2-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/35378884"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://8948-15778896-gh.circle-artifacts.com/0/lmms-1.2.3-712%2Bg6de03e132-mac10.13.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/8948?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "2e295a397ef1ce406a852c6d46e130eaf47e1e1e"}

@ryuukumar ryuukumar mentioned this pull request Jul 21, 2020
Closed
56 tasks
@JohannesLorenz
Copy link
Contributor Author

It failed for the reasons that will be fixed in #5536 . So I will merge this, but I will wait until 5536 has been fixed (in order to not crash our CI every time).

@JohannesLorenz JohannesLorenz marked this pull request as ready for review August 22, 2020 23:13
JohannesLorenz added a commit that referenced this pull request Sep 21, 2020
@JohannesLorenz
basics: Change sampleFrame to use std::array (#5536)
6d160fd 
... in order to make standard containers be able to store it. Required for
#5532 (#4899) and the recording PR.

This includes:

* removing the `LocklessRingBuffer<sampleFrame>` specialization
* passing samplerame in `StereoDelay::tick` as a reference

Additional cleanups:

* removing already unused typedef `sampleFrameA`
* add some `const_cast` to make code more readable
@JohannesLorenz JohannesLorenz merged commit 6546857 into LMMS:master Sep 24, 2020
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
@JohannesLorenz
basics: Change sampleFrame to use std::array (LMMS#5536)
a7c0b0a 
... in order to make standard containers be able to store it. Required for
LMMS#5532 (LMMS#4899) and the recording PR.

This includes:

* removing the `LocklessRingBuffer<sampleFrame>` specialization
* passing samplerame in `StereoDelay::tick` as a reference

Additional cleanups:

* removing already unused typedef `sampleFrameA`
* add some `const_cast` to make code more readable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohannesLorenz @LmmsBot