Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make better use of getSelectedNotes() in PianoRoll.cpp #5526

Merged
merged 4 commits into from
Jun 15, 2020
Merged

Make better use of getSelectedNotes() in PianoRoll.cpp #5526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b28bc8d
Make better use of getSelectedNotes() in PianoRoll.cpp
Spekular Jun 4, 2020
dce0463
Save and reuse selected note vector more often
Spekular Jun 4, 2020
bd17bc8
Apply review suggestions
Spekular Jun 4, 2020
3b4568e
Comment, style, consistency
Spekular Jun 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions include/PianoRoll.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ class PianoRoll : public QWidget
const QColor & selCol, const int noteOpc, const bool borderless, bool drawNoteName );
void removeSelection();
void selectAll();
NoteVector getSelectedNotes();
NoteVector getSelectedNotes() const;
void selectNotesOnKey();
int xCoordOfTick( int tick );

Expand All @@ -212,7 +212,7 @@ protected slots:
void copySelectedNotes();
void cutSelectedNotes();
void pasteNotes();
void deleteSelectedNotes();
bool deleteSelectedNotes();

void updatePosition(const MidiTime & t );
void updatePositionAccompany(const MidiTime & t );
Expand Down Expand Up @@ -294,7 +294,9 @@ protected slots:
MidiTime newNoteLen() const;

void shiftPos(int amount);
void shiftPos(NoteVector notes, int amount);
void shiftSemiTone(int amount);
void shiftSemiTone(NoteVector notes, int amount);
bool isSelection() const;
int selectionCount() const;
void testPlayNote( Note * n );
Expand Down
Loading