Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Piano roll vertical zoom #5442

Merged
merged 10 commits into from
Apr 30, 2020
Merged

Piano roll vertical zoom #5442

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a4909e6
Preparing piano roll for changing the height of the keys.
akimaze Apr 7, 2020
5fca16b
Implemented piano roll vertical zooming.
akimaze Apr 7, 2020
c69f026
Removed static from PianoRoll:drawNoteRect() and s_keyLineHeight --> …
akimaze Apr 14, 2020
ff519e4
Unnecessary round() when multiplying by 2.
akimaze Apr 14, 2020
460ffd9
Center note text vertically.
akimaze Apr 16, 2020
c1ddc58
Simplification of calculations.
akimaze Apr 16, 2020
4de220f
Better note text height calculation (proposed by PhysSong).
akimaze Apr 20, 2020
101c0d2
Fixed white keys names positions.
akimaze Apr 21, 2020
78f835e
Change fontMetrics.boundingRect().height() to - boundingRect.top() - …
akimaze Apr 23, 2020
1153549
Changed name from fontHeight to labelHeight.
akimaze Apr 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 15 additions & 11 deletions src/gui/editors/PianoRoll.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2867,6 +2867,8 @@ void PianoRoll::paintEvent(QPaintEvent * pe )

// set font-size to 8
p.setFont( pointSize<8>( p.font() ) );
QFontMetrics fontMetrics(p.font());
int const fontHeight = fontMetrics.boundingRect(QChar::fromLatin1('H')).height();
PhysSong marked this conversation as resolved.
Show resolved Hide resolved

// y_offset is used to align the piano-keys on the key-lines
int y_offset = 0;
Expand Down Expand Up @@ -2961,20 +2963,22 @@ void PianoRoll::paintEvent(QPaintEvent * pe )
int yCorrectionForNoteLabels = 0;

int keyCode = key % KeysPerOctave;
switch( keyCode )
switch (keyCode)
{
case 0:
case 5:
yCorrectionForNoteLabels = -4;
case 0: // C
case 5: // F
yCorrectionForNoteLabels = (m_whiteKeySmallHeight - fontHeight + 1) / -2;
break;
case 2:
case 7:
case 9:
yCorrectionForNoteLabels = -2;
case 2: // D
case 7: // G
case 9: // A
yCorrectionForNoteLabels = (m_whiteKeyBigHeight / 2 - fontHeight + 1) / -2;
break;
case 4:
case 11:
yCorrectionForNoteLabels = 2;
case 4: // E
case 11: // B
// calculate center point of key and move half of text
yCorrectionForNoteLabels = -(((m_whiteKeySmallHeight - (m_whiteKeySmallHeight * 2 + 3) / 6) / 4)
- fontHeight / 2);
break;
}

Expand Down