-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make MIDI controller's buttons assignable #5356
Open
artur-twardowski
wants to merge
4
commits into
LMMS:master
Choose a base branch
from
artur-twardowski:midi-controller-buttons
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Make MIDI controller's buttons assignable #5356
artur-twardowski
wants to merge
4
commits into
LMMS:master
from
artur-twardowski:midi-controller-buttons
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when assinging a controller to an automatable model. Add appropriate API in MidiPort.
🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩
Linux
Windows
🤖{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://5545-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.580-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/5545?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://5544-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.580-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/5544?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://5547-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.580-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/5547?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/7f4wxsd2cjghi85r/artifacts/build/lmms-1.2.1-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/29781610"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/xbet4myhi55lyk0q/artifacts/build/lmms-1.2.1-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/29781610"}]}, "commit_sha": "d4b6dcd910f9ea814a5a96ac19af2dddbf8edde0"} |
PhysSong
added
needs code review
A functional code review is currently required for this PR
needs style review
A style review is currently required for this PR
needs testing
This pull request needs more testing
labels
Apr 25, 2020
56 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs code review
A functional code review is currently required for this PR
needs style review
A style review is currently required for this PR
needs testing
This pull request needs more testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a possibility to assign keys or buttons to automatable controls.
While some MIDI keyboards allow assigning push buttons to CCs, other MIDI devices such as AKAI Midimix trigger Note On and Note Off messages. In current implementation it is not possible to link those buttons with on-screen controls. One can use a slider or a knob instead, but a physical push button is much more relevant for on-off switches, especially when working with plugins such as OpulenZ that exposes 11 "LEDs".
The change proposed adds two modes of operation when dealing with Note On and Note Off messages:
Change in scope of #1472 (proposed by me in a comment), it also addresses #1815.
Note: I had to remove the infamous octave-shifting code from MIDI clients, however I see that some proper solution is now being worked on in #5349. Maybe the aforementioned change needs to be merged first, then this PR should be rebased on top of it.