Fix browser 'Factory files' delimiter position #5296
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zonkmachine
added
needs code review
|
More info in comments here: #3183 (comment) |
zonkmachine
commented
Nov 17, 2019
|
I'll unassign this after talking with Curlymorphic. The reviewer also might want to check that this will not cause regression of #1150 . |
|
FYI I'll review this now. |
|
After we talked about this, this was the wrong solution. I'll close this, the correct PR is #5378 . Thanks still for the fix, feel free to reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the factory file delimiter in the browser tree is placed wrong where there are user added directories. Lingering issue from #1150. Earlier fixed in #2665 and #1505.
Fixes #3183