Remove MIDI connections from factory .mmpz files #5163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! It's a bit of a hazzle to compare the files as it's compressed stuff. Maybe the project files should be in .mmp format in the source and then compressed when building? Anyway, here's an example of the issue/fix. In shorties/DirtyLove.mmpz open the FXMixer and right click the master mute. It is connected to a MIDI channel. --- /home/zonkmachine/lmms/projects/bugs/dirtymidiorig.mmp
+++ /home/zonkmachine/lmms/projects/bugs/dirtymidi.mmp
@@ -1944,11 +1944,6 @@
</key>
</effect>
</fxchain>
- <connection>
- <muted>
- <Midicontroller outputchannel="1" outputcontroller="0" basevelocity="127" name="MIDI ch1 ctrl37" outputprogram="1" fixedinputvelocity="-1" fixedoutputvelocity="-1" fixedoutputnote="-1" inputchannel="1" inputcontroller="37" inports="" readable="1" type="2" writable="0"/>
- </muted>
- </connection>
</fxchannel>
<fxchannel muted="0" num="1" name="Beat" volume="0.56" soloed="0">
<fxchain enabled="1" numofeffects="3">I think this can be merged. |
zonkmachine
approved these changes
Sep 7, 2019
|
Merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #4207, I missed
.mmpzfiles as I couldn'tgrepthem directly. MIDI connections in those files may affect other project files due to #3790.