Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make splash screen text white, themeable #5149

Merged
merged 4 commits into from
Aug 27, 2019
Merged

Make splash screen text white, themeable #5149

merged 4 commits into from
Aug 27, 2019

Conversation

Spekular
Copy link
Member

Closes #5023

Spekular
Spekular commented Aug 25, 2019
View reviewed changes
Copy link
Member Author

@Spekular Spekular left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Themeable solution, part 1.

src/gui/GuiApplication.cpp Outdated Show resolved Hide resolved
src/gui/GuiApplication.cpp Outdated Show resolved Hide resolved
@Spekular Spekular changed the title Make splash screen text white Make splash screen text white, themeable Aug 25, 2019
@Spekular
Copy link
Member Author

This should probably be squashed into one commit if/when merged.

@tresf
Copy link
Member

tresf commented Aug 26, 2019

@Spekular I recommend doing it without code changes if possible...

QSplashScreen QLabel {
	color: white;
}

@Spekular
Copy link
Member Author

Huh. GuiApplication QLabel { //stuff } seemed to either do nothing or break the theme (I don't recall which, I tried a few different things) so I figured that kinda thing wouldn't work.

Will fix.

@PhysSong
Copy link
Member

I tested @tresf's solution locally. It seems to work.

Spekular
Spekular commented Aug 27, 2019
View reviewed changes
Copy link
Member Author

@Spekular Spekular left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tresf 's suggestions

data/themes/default/style.css Outdated Show resolved Hide resolved
data/themes/default/style.css Outdated Show resolved Hide resolved
data/themes/default/style.css Show resolved Hide resolved
src/gui/GuiApplication.cpp Outdated Show resolved Hide resolved
src/gui/GuiApplication.cpp Outdated Show resolved Hide resolved
@tresf tresf merged commit 8568ae4 into LMMS:stable-1.2 Aug 27, 2019
@Spekular Spekular deleted the patch-5 branch August 10, 2020 15:24
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
@Spekular @tresf
Make splash screen text white (LMMS#5149)
dcbaf70 
Make splash screen text white
Closes LMMS#5023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Spekular @tresf @PhysSong