-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'Change color' option to mixer channels #5085
Conversation
I gave it a test, it seems to work fine for the most part. I did notice one very minor bug where resetting the color of the selected bus to default doesn't update the color on the screen until you click on the channel or switch to another channel. Also, how the colors are handled may need some discussion. From what I can see, any unselected channels are combined with the color black, which can make the channel colors look ugly. Maybe instead, we should make the default-colored channels the dark color, and then mix the selected channel with the color white? Any opinions? Maybe that would break some LMMS themes, I'm not sure. Otherwise, I did not notice any bugs or problems. 👍 |
The bug fixed. 👍 |
I agree with @douglasdgi, we should lighten the selected channel rather than darkening all the unselected ones. Qt has a function |
It colors "song editor" too, or only mixer? |
It has no effect on the song editor. I agree with @douglasdgi and @noahb01. Pushing changes which make it work the opposite way to what I have implemented. |
To remove the GUI dependency added in this PR, some extra changes are needed to loading/saving FX channel settings. |
Didn't know this existed... made a PR #5589 which does this same thing. |
@russiankumar Too bad. Is there any chance this can get reviewed, tested and merged soon? |
I kind of see no point, considering the newer one can already be merged without any rebasing hassle, while this one will have to wait. The newer one was already tested by some as well, seems to work as expected, so I’d just go with that one. Though I want a mod to confirm this, since technically I’m biased. |
Probably the best, especially since this seems not to be very active at the moment. |
Superceded by #5589, which is now merged. |
This enables the user to choose whatever color they want for a mixer channel. This is my first... bigger(?) PR, so don't be surprised if something's wrong. 😝