-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for the SF2 with no "default" patch #5084
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work, and sorry for the late response.
Here are some feedbacks.
Hey @PhysSong, |
I think it's Homebrew acting up a bit. Restarting the Mac build a couple of times worked. |
Sounds good, I would have thought that since Mac OS was POSIX compliant that it would have just been compatible but hombrew tool is something else. |
Using the instructions from #323 to test the fix for this PR, I was able to reproduce the problem and provide a fix. Let me know if there is anything else that is left from the issue.