Use "bar" instead of "tact"

[M374LX]

Closes #4865.

[qnebra]

I think in code is unnecessary to change from tact to bar. Only in user space maybe.

[BaraMGB]

In my opinion this is a good idea. Helps new people to understand what's going on.

[tresf]

I think in code is unnecessary to change from tact to bar. Only in user space maybe.

No, that would be worse. The word tact is a common complaint amongst new developers; this is an improvement.

There are a few unnecessary whitespace additions/subtractions, but they're in files that are already inconsistent. This looks good to merge. I'm not as actively involved with the codebase/open PRs as a few others. @PhysSong would you be comfortable merging this?

[PhysSong]

@PhysSong would you be comfortable merging this?

No objections.

[JohannesLorenz]

If tresf and PhysSong have no objections, I'll consider this as accepted.

I'll start a review.

[JohannesLorenz]

I left 6 comments. Can you please see if you can change that?

[JohannesLorenz]

BUMP @M374LX 😃

[PhysSong]

@JohannesLorenz Can you see if your comments are addressed properly?

[LmmsBot]

🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩

Linux

• Linux (AppImage): lmms-1.2.1.555-linux-x86_64.AppImage (build link)

Windows

• Windows 32-bit: lmms-1.2.1.555-mingw-win32.exe (build link)
• Windows 64-bit: lmms-1.2.1.555-mingw-win64.exe (build link)

🤖

{"commit_sha": "16c760ceb49f321f8f1fbd2edc03a3c294a2f907", "platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://4797-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.555-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/4797?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://4795-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.555-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/4795?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://4796-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.555-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/4796?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}}

[lukas-w]

I assume the last open request #4878 (comment) by @JohannesLorenz was resolved by 16c760c. I'll squash some commits and merge this.

[lukas-w]

Merged via 53e6b64 and 46f5433,