Support Bezier curves for automation patterns #4674
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No crashes when I worked in lmms with this branch (and a lot others) merged on quite challenging project is a good sign. |
56 tasks
1 task
PhysSong
force-pushed
the
feature/bezier
branch
from
ed07693 to
9c21d0b
Compare
🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩
Linux
Windows
macOS🤖{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://11473-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.46%2Bg9c21d0b-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/11473?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://11472-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.46%2Bg9c21d0b4d-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/11472?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://11470-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.46%2Bg9c21d0b4d-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/11470?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/120e3m6bnf10xf4n/artifacts/build/lmms-1.3.0-alpha-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/36753678"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/21dtirggyu3usyvv/artifacts/build/lmms-1.3.0-alpha-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/36753678"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/28j5r7r1ud0oqats/artifacts/build/lmms-1.3.0-alpha-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/36753681"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/s630a5jvkik9id4v/artifacts/build/lmms-1.3.0-alpha-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/36753681"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://11471-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.46%2Bg9c21d0b4d-mac10.14.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/11471?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "9c21d0b4d82bf416a6ff07ff8bdfe8949ea73827"} |
|
This pull request now have massive merge conflicts due to #5712 and class renames. I will try to resolve them after refactor. |
PhysSong
added
after-refactor
|
I think I should wait for #5924, which is very likely to contain a lot of duplicated works. |
|
I believe this can be resurrected |
Yes, I just don't have enough time for now(until the end of this month). |
|
I'll possibly redo the work because of the large changes in the codebase. |
|
I'm moving this out of the 1.3 milestone, as @PhysSong might not have time to complete this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request continues #2466 which was done by @codythecoder. Note that I haven't tested this feature much yet.
Closes #2381.