Add Carla automation support #4571

ghost · 2018-08-30T16:12:42Z

Thanks PhysSong for the review in the previous PR.

Converted all indentation to tabs.
Added whitespaces (coding style).
Removed EffectControls.h from carla.cpp
Removed QtDebug from carla.cpp, it wasn't needed anymore.
Signal/Slots Qt4 support.

LmmsBot · 2018-08-30T16:29:36Z

Downloads for this pull request

Windows 32 Bit: download.
Windows 32 Bit: download.
Windows 64 Bit: download.
Windows 64 Bit: download.
Windows 32 Bit: download.
Windows 64 Bit: download.

Generated by the LMMS pull requests bot.
SHA: 5d06520

PhysSong · 2018-09-14T03:44:44Z

Converted all indentation to tabs.

Sorry, What I mean was keeping consistency in new code, not changing old code.

ghost · 2018-09-18T15:08:22Z

@PhysSong ; Ok do you want me to change them to spaces again? (I’ll prefer the tabs BTW.)

I'm also working on putting the parameters in a subwindow since some Carla plugins have a lot of parameters. I have working code for this, but it needs to be cleaned before I put it online.

Other thoughts of adding are giving the user the ability to colour a knob so it stands out and it easy recognisable. And adding a search/filter bar that will result in only showing knobs with matching names.

PhysSong · 2018-09-20T05:46:04Z

It seems like you messed up the ZynAddSubFX submodule while merging branches, but it's okay. I can fix that before merging if you want.

plugins/carlabase/carla.cpp

plugins/carlabase/carla.h

plugins/carlabase/carla.cpp

plugins/carlabase/carla.h

PhysSong · 2018-09-20T11:20:30Z

Ok do you want me to change them to spaces again? (I’ll prefer the tabs BTW.)

We use tabs for indentation, but indentation changes make it harder to view changes. I think we should convert them to tabs eventually.
Feel free to do what you want for new code, but I think we should preserve old code for now.
Also, please use new coding styles for new code. You are mixing old and new conventions in some places.

// old
if( a )
{
	b( c );
}
// new
if (a)
{
	b(c);
}

Also, note that if (a) is simpler than if (a == true), the same for false.

PhysSong · 2018-09-20T14:02:38Z

Since master branch doesn't support Qt4, you can revert knob connection as you did in #4569 (review) . Functor-based connections look cleaner than the current way to me.

ghost · 2018-09-20T18:12:23Z

@PhysSong

About the messed up ZynAddSubFX submodule: Hmm I didn’t touch anything but carla.h and carla.cpp, did I have to remove the submodules before merging with the upstream? And yes please fix it before merging if you would.

I made some changes (see commit log) in response to your review, thanks again :-)

PhysSong

I've suggested some improvements and cleanups. Sorry for the late response.

plugins/carlabase/carla.cpp

falkTX · 2018-11-13T07:03:44Z

Just saw this, note that carla will have a way to handle automation in plugin mode "soon".
The base work for it is already done

ghost · 2018-11-15T10:18:12Z

Hello @falkTX , can you tell what that does mean for this PR? And the done base work, is it on the Carla git repo so we can follow it?

falkTX · 2018-11-15T10:36:40Z

Only the code that allows the actual automation of plugin parameters is in place, so nothing to see yet.
Previously the rack and patchbay engine modes would misbehave on variable process cycles, that hosts use for sample-accurate automation.
WIth that fixed, there is no more blocker to exposing some parameters in carla plugin versions.

My idea is to have a static number of parameters (say, 100), that the user can map to a specific plugin parameter. I have to expose the 100 parameters in the plugin code, and then design a new UI for this.

ExperiBass · 2019-01-17T03:32:24Z

Lemmie just revive for a sec:
I ran this on MacOS Mojave, and i like it. The issues i have with it is that i can only automate the first vst in the list, or the instrument vst. It for some reason cant grab the automatable knobs in a new carla entity(?). It only got them in a existing project.

ghost · 2019-01-17T20:58:33Z

@gingkathfox

i can only automate the first vst in the list, or the instrument vst.

I’m not sure if it’s currently possible with Carla yet, but I will look into it.

It for some reason cant grab the automatable knobs in a new carla entity(?). It only got them in a existing project.

I don’t quite understand, what do you mean by grab then? Grab and drag to a automation track? And this only happens when you add a new Carla Patchbay/Rack instance? What about after saving and reopening the project, does it work then?

If you can tell me what version of Carla you use, I will try to reproduce on Linux, I don’t have access to a Mac.

ExperiBass · 2019-01-18T01:24:52Z

@cyberdevilnl the knobs wont show up in the knob menu. they only show up in existing Carla projects. im using Carla 1.9.12 2.0 RC2.

ExperiBass · 2019-01-18T01:25:19Z

and no, saving and reopening wont show the knobs either.

ghost · 2019-01-21T07:46:19Z

I have found a way to get a list of loaded plugins by Carla but this is kinda tricky. Also I haven’t found a way to get dispatched by Carla on the changes of plugins. A lot of questions come to mind on how to handle such events, some examples:

Unique identifier.

The CarlaBackend::CarlaPlugin->getUniqueId() method isn’t reliable since most plugins I tested didn’t supply one. We can work around that by using getName() wich should be unique but it isn’t perfect. What about this:

User removes a plugin.
User adds another plugin.
User renames that plugin to the same name as the previously removed plugin.

Index (Id)

We can access a plugin by their Id through CarlaBackend::CarlaEngine→getPlugin(i). But if the order of the plugins changes inside Carla so will their Id’s.

So I think it’s best to leave it this way and wait till the static number of parameters feature @falkTX mentioned (#4571 (comment)) is implemented, then change this code to work with that.

Also I’ve found two bugs in the current code. will fix that asap.

Bug 1: If there are knobs loaded, remove all plugins inside Carla, then reload knobs and the old knobs won’t be removed. It should be empty.
Bug 2: If there are no knobs, pushing refresh values will crash LMMS.

Oh and @gingkathfox, just to be sure did you press the refresh parameter knobs button after you loaded a plugin inside Carla? If not with current code you should, like I said I haven’t found a way yet to get dispatched on plugin changes inside Carla so till then you have to press the button manually after loading a plugin inside Carla.

falkTX · 2019-01-21T08:04:36Z

I appreciate the enthusiasm here to try to get this working.
But you know I am right here so you can ask me stuff on how Carla works, right?

Anyway, a proper implementation of this will need changing the code in carla.
Otherwise we just hack around it, and then have to maintain it as well, which is not nice.

You are already in the right path by using the native plugin parameter API.
I have not yet decided how many parameters will be exposed, but at least 25 (static).

ExperiBass · 2019-01-21T08:50:08Z

@cyberdevilnl i did, still didnt work.

… LMMS. * Fix bug: If there are knobs loaded, remove all plugins inside Carla, then reload knobs and the old knobs won’t be removed. It should be empty. * Some styling issues.

* Set window title on central widget so it is visible.

…ide. Just emit and accept.

* Added `overrride` to `CarlaParamsSubWindow::closeEvent`

…`m_curColumn` and `m_curRow`.

ghost · 2019-10-14T20:33:48Z

With Carla 2.0 we need to refresh the params and their values manual. With the develop branch of Carla it can be done automaticly, it however only works for the parameters of the first plugin inside Carla, in the future Carla should get all parameters until the max parameters is reached. (This is still TODO for Carla.)

What this means for this PR: It can be used if the behaviour of manual refreshing the parameters is acceptable. If it is not then we have to wait until Carla 2.1 is released. I'm in for waiting until the Carla 2.1 release.

I created another branch on my LMMS fork with code that's working for Carla develop branch. https://github.com/CYBERDEViLNL/lmms/tree/master_carla

Please let me know what we want to do here so I can update this PR or create a new one.

PhysSong · 2020-12-10T03:25:26Z

Anyway, a proper implementation of this will need changing the code in carla.
Otherwise we just hack around it, and then have to maintain it as well, which is not nice.

@falkTX How is that going on? We have Carla 2.2.0 now.

falkTX · 2020-12-10T12:17:49Z

Anyway, a proper implementation of this will need changing the code in carla.
Otherwise we just hack around it, and then have to maintain it as well, which is not nice.

@falkTX How is that going on? We have Carla 2.2.0 now.

This is fully supported now, exposed in Carla internal plugin as well as in the Carla VST2 version.

There is a callback on carla plugin API for when a refreshing of the parameter list needs to be done (basically everytime a plugin is added, removed or reordered).
There parameters are even grouped by plugin.

Here is how it looks for the carla-rack plugin inside of carla:

PhysSong · 2020-12-12T23:34:07Z

Closing in favor of #5846.

PhysSong · 2020-12-26T02:42:10Z

...And I didn't really close this. 😂

tinkerlevu · 2021-01-20T04:32:39Z

Hey wait a minute, speaking of 'getting merged', if this issue is moved to #5846, why is this still in https://github.com/LMMS/lmms/projects/11?

ghost mentioned this pull request Aug 30, 2018

Add automation support for Carla. #4569

Closed

PhysSong reviewed Sep 20, 2018

View reviewed changes

plugins/carlabase/carla.cpp Outdated Show resolved Hide resolved

plugins/carlabase/carla.h Outdated Show resolved Hide resolved

plugins/carlabase/carla.cpp Outdated Show resolved Hide resolved

plugins/carlabase/carla.h Outdated Show resolved Hide resolved

tresf mentioned this pull request Sep 29, 2018

Use Carla as an effect. #4634

Open

PhysSong reviewed Nov 3, 2018

View reviewed changes

plugins/carlabase/carla.cpp Outdated Show resolved Hide resolved

plugins/carlabase/carla.cpp Outdated Show resolved Hide resolved

plugins/carlabase/carla.cpp Outdated Show resolved Hide resolved

PhysSong changed the title ~~Added Carla automation support.~~ Add Carla automation support Nov 8, 2018

JohannesLorenz added the pr-wip label Apr 17, 2019

PhysSong added in progress and removed pr-wip labels Apr 22, 2019

CYBERDEViLNL added 4 commits October 4, 2019 15:47

Re-add changes after reset to upstream master.

d3e0010

* Fix crash: If there are no knobs, pushing refresh values will crash…

0840bf2

… LMMS. * Fix bug: If there are knobs loaded, remove all plugins inside Carla, then reload knobs and the old knobs won’t be removed. It should be empty. * Some styling issues.

Only hide subwindow.

5b00cca

* Oops, reverse removing those parentheses.

8850b02

* Set window title on central widget so it is visible.

CYBERDEViLNL added 7 commits October 9, 2019 00:20

if not init then QString idStr doesn't need to exist.

9305312

Subwindow already has attribute Qt::WA_DeleteOnClose, so no need to h…

e8dee5e

…ide. Just emit and accept.

remove spaces from empty line in header

af70630

* Remove empty destructor from CarlaParamsSubWindow.

cc65487

* Added `overrride` to `CarlaParamsSubWindow::closeEvent`

Renamed floatModels to m_paramModels.

d842002

Renamed settingsElem to m_settingsElem.

1686f03

Renamed lMaxColumns, lCurColumn and lCurRow to m_maxColumns, …

5d06520

…`m_curColumn` and `m_curRow`.

akimaze added a commit to akimaze/lmms that referenced this pull request Jul 5, 2020

Changes from PR LMMS#4571.

8f96558

MaciejMalczyk mentioned this pull request Jul 5, 2020

Rack with controls to send Midi CC messages. #5558

Closed

akimaze added a commit to akimaze/lmms that referenced this pull request Jul 11, 2020

Changes from PR LMMS#4571.

c674374

ryuukumar mentioned this pull request Jul 21, 2020

Reorganising LMMS, renaming editors and classes and everything in between (cont. #120) #5592

Closed

56 tasks

akimaze added a commit to akimaze/lmms that referenced this pull request Jul 24, 2020

Changes from PR LMMS#4571.

caa0125

akimaze added a commit to akimaze/lmms that referenced this pull request Aug 11, 2020

Changes from PR LMMS#4571.

e56154f

akimaze added a commit to akimaze/lmms that referenced this pull request Aug 22, 2020

Changes from PR LMMS#4571.

c79e8b0

MaciejMalczyk mentioned this pull request Sep 22, 2020

Adds support for MIDI CC events inside LMMS #5581

Merged

cyber-bridge mentioned this pull request Dec 12, 2020

Feature: Carla automation #5846

Merged

PhysSong closed this Dec 26, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Carla automation support #4571

Add Carla automation support #4571

ghost commented Aug 30, 2018

LmmsBot commented Aug 30, 2018 •

edited

Loading

PhysSong commented Sep 14, 2018

ghost commented Sep 18, 2018

PhysSong commented Sep 20, 2018

PhysSong commented Sep 20, 2018

PhysSong commented Sep 20, 2018

ghost commented Sep 20, 2018

PhysSong left a comment

falkTX commented Nov 13, 2018

ghost commented Nov 15, 2018

falkTX commented Nov 15, 2018

ExperiBass commented Jan 17, 2019

ghost commented Jan 17, 2019

ExperiBass commented Jan 18, 2019

ExperiBass commented Jan 18, 2019

ghost commented Jan 21, 2019

falkTX commented Jan 21, 2019

ExperiBass commented Jan 21, 2019

ghost commented Oct 14, 2019

PhysSong commented Dec 10, 2020

falkTX commented Dec 10, 2020

PhysSong commented Dec 12, 2020

PhysSong commented Dec 26, 2020

tinkerlevu commented Jan 20, 2021 •

edited

Loading

Add Carla automation support #4571

Add Carla automation support #4571

Conversation

ghost commented Aug 30, 2018

LmmsBot commented Aug 30, 2018 • edited Loading

Downloads for this pull request

PhysSong commented Sep 14, 2018

ghost commented Sep 18, 2018

PhysSong commented Sep 20, 2018

PhysSong commented Sep 20, 2018

PhysSong commented Sep 20, 2018

ghost commented Sep 20, 2018

PhysSong left a comment

Choose a reason for hiding this comment

falkTX commented Nov 13, 2018

ghost commented Nov 15, 2018

falkTX commented Nov 15, 2018

ExperiBass commented Jan 17, 2019

ghost commented Jan 17, 2019

ExperiBass commented Jan 18, 2019

ExperiBass commented Jan 18, 2019

ghost commented Jan 21, 2019

Unique identifier.

Index (Id)

falkTX commented Jan 21, 2019

ExperiBass commented Jan 21, 2019

ghost commented Oct 14, 2019

PhysSong commented Dec 10, 2020

falkTX commented Dec 10, 2020

PhysSong commented Dec 12, 2020

PhysSong commented Dec 26, 2020

tinkerlevu commented Jan 20, 2021 • edited Loading

LmmsBot commented Aug 30, 2018 •

edited

Loading

tinkerlevu commented Jan 20, 2021 •

edited

Loading