Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VST fixes again #4540

Merged
merged 7 commits into from
Sep 11, 2018
Merged

VST fixes again #4540

merged 7 commits into from
Sep 11, 2018

Commits on Aug 14, 2018

  1. Suspend plugin when changing sample rate/buffer size

    Some plugins ignore updates to these values if they're changed while the plugin is in a "resumed" state, resulting in incorrect tuning after a change of sample rate.
    DomClark committed Aug 14, 2018
    Configuration menu
    Copy the full SHA
    e5cc1a1 View commit details
    Browse the repository at this point in the history
  2. Fix hang when updateInOutCount called from processReplacing

    Ignore requests to change the I/O count from within processReplacing and print a warning instead; the shared memory is in use so it can't be reallocated. Add a special case to return immediately if the I/O count hasn't changed at all; this will prevent spurious warnings when the plugin is only updating the latency and should reduce unnecessary reallocations in general.
    DomClark committed Aug 14, 2018
    Configuration menu
    Copy the full SHA
    4c1d617 View commit details
    Browse the repository at this point in the history
  3. Fix kVstTransportChanged flag usage in VST sync

    Changed according to feedback from AudioBlast. The flag used to be set most of the time, now it is only set when playback starts/stops, looping is toggled, or playback jumps around.
    DomClark committed Aug 14, 2018
    Configuration menu
    Copy the full SHA
    a4e1a0b View commit details
    Browse the repository at this point in the history
  4. Fix VST windows resizing a little incorrectly

    This was fixed for setting the initial size of the window in 8e9f74d, but I missed the resizing case.
    DomClark committed Aug 14, 2018
    Configuration menu
    Copy the full SHA
    b9a8186 View commit details
    Browse the repository at this point in the history
  5. Link RemoteVstPlugin with -mwindows

    Stops each remote plugin process spawning a console host, and seems more in line with what other hosts do.
    DomClark committed Aug 14, 2018
    Configuration menu
    Copy the full SHA
    edf2365 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2018

  1. Initialise OLE in RemoteVstPlugin

    Some plugins don't initialise it themselves, expecting it already to be
    done for them, and so are liable to hang without it (e.g. TX16Wx).
    
    Co-authored-by: Hyunjin Song <tteu.ingog@gmail.com>
    Co-authored-by: Dominic Clark <mrdomclark@gmail.com>
    3 people committed Aug 17, 2018
    Configuration menu
    Copy the full SHA
    8e6ee6f View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2018

  1. Set VST program first when restoring settings

    Fixes a bug where some VSTs (e.g. Temper) would have their settings reset on project load, due to using programs as presets.
    DomClark committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    3af9e26 View commit details
    Browse the repository at this point in the history