Quit exit if failing to save project #4428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zonkmachine
commented
Jun 16, 2018
| @@ -1022,8 +1024,7 @@ bool MainWindow::saveProjectAsNewVersion() | |||
| do VersionedSaveDialog::changeFileNameVersion( fileName, true ); | |||
| while ( QFile( fileName ).exists() ); | |||
|
|
|||
| Engine::getSong()->guiSaveProjectAs( fileName ); | |||
| return true; | |||
| return Engine::getSong()->guiSaveProjectAs( fileName ); | |||
There was a problem hiding this comment.
I'm not sure how to make MainWindow::saveProjectAsNewVersion() return false for the purpose of testing, but the function returns a bool and this looks correct. Still works.
There was a problem hiding this comment.
Easy to test. Just create a directory with test files and change ownership to root. Load and change one of the files and then saveAsNewVersion/(). Works as expected both with and without this change.
PhysSong
approved these changes
Jun 17, 2018
|
Looks good for me. |
|
OK. I need to test this some more though. |
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
* Quit exiting when failing to save project *Test outcome of save in MainWindow::saveProjectAsNewVersion()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test for, and return the result of,
Engine::getSong()->guiSaveProject()when saving a project.Fixes #4426