Refactoring: Memory management #4311
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use a Nifty Counter for rpmalloc initialization. This fixes init order with other static objects using MmAllocator or MemoryManagger * Fix exception throwing in AlignedAllocator * Add missing constructor to MmAllocator for compatibility with std containers
MemoryPool maintains a free list of pre-allocated entries stored in a libcds MPMC Queue. In contrast to LocklessAllocator, it's a lot faster, less (and less complex) code to maintain for us and it doesn't fail when it's full.
|
Should have tested with Travis first. Will re-open once fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some refactorings regarding memory management and containers.
MemoryManager.hrenamed toMemory.hMemoryHelper::alignedMallocmoved toMemory.h, ported to an stl-compatible allocator calledAlignedAllocator, implementation replaced by a single rpmalloc call.LocklessAllocatorimplementation replaced by a newMemoryPoolclass, which now also replaces the implementations ofBufferPool(formerlyBufferManager) andNotePlayHandlePool(formerlyNotePlayHandleManager). Instead of a custom-written lockless stack,MemoryPooluses a 3rdparty lockless queue implementation which yields much better performance.This includes a a new submodule,
libcds, which is a collection of concurrent and lock-free data structures.Starting with this PR, I'd like to license my contributions as MIT, while the project as a whole is still licensed as GPL. Hope that doesn't cause any trouble.