Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Pitch automation improvements in Piano Roll #41

Merged
merged 3 commits into from
Jan 17, 2014
Merged

WIP: Pitch automation improvements in Piano Roll #41

merged 3 commits into from
Jan 17, 2014

Conversation

grejppi
Copy link
Contributor

@grejppi grejppi commented Jan 17, 2014

I've started making some usability improvements to the detuning feature in the piano roll.
(Reopened as a pull request, as it makes more sense that way)

A list of goals:

  • First point doesn't have to be 0
  • Correct scale
  • Draw lines instead of just points:
  • Discrete
  • Linear
  • Spline
  • Don't display the initial point if there is no automation

Optionally:

  • Edit automation directly in the piano roll

@grejppi grejppi mentioned this pull request Jan 17, 2014
Closed
tobydox added a commit that referenced this pull request Jan 17, 2014
@tobydox
Merge pull request #41 from grejppi/stable-0.4-pitchautomation
6d0c544 
WIP: Pitch automation improvements in Piano Roll
@tobydox tobydox merged commit 6d0c544 into LMMS:stable-0.4 Jan 17, 2014
@grejppi grejppi deleted the stable-0.4-pitchautomation branch January 17, 2014 09:40
@grejppi grejppi mentioned this pull request Jan 17, 2014
Merged
@meschi meschi mentioned this pull request Jun 17, 2014
Closed
@bwoosley bwoosley mentioned this pull request Aug 23, 2014
Closed
@Sti2nd
Copy link
Contributor

Sti2nd commented Nov 21, 2014

What would spline mean, @grejppi ?

@psilhavy psilhavy mentioned this pull request May 14, 2015
Closed
@tresf tresf mentioned this pull request Feb 6, 2018
Closed
@firewall1110 firewall1110 mentioned this pull request Sep 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grejppi @Sti2nd @tobydox