Ogg files - Silence warning message and fix obsolete vorbis tag message #3634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good. The output compares to Audacity. I'll merge this tomorrow if there are no complaints. |
We give the stream a unique serial number and make sure it isn't '0' or 'UINT_32_MAX'. Change obsolete 'Linux MultiMedia Studio' to 'LMMS' in ogg file comment.
This is nice, but as a reminder, we should target non-critical fixes at master. :) |
tresf
pushed a commit
to liushuyu/lmms
that referenced
this pull request
Jun 12, 2017
We give the stream a unique serial number and make sure it isn't '0' or 'UINT_32_MAX'. Change obsolete 'Linux MultiMedia Studio' to 'LMMS' in ogg file comment.
|
OK ... ;) |
|
Cherry-picked and ready for master via cb68c96. |
PhysSong
pushed a commit
to PhysSong/lmms
that referenced
this pull request
Jul 8, 2017
We give the stream a unique serial number and make sure it isn't '0' or 'UINT_32_MAX'. Change obsolete 'Linux MultiMedia Studio' to 'LMMS' in ogg file comment.
PhysSong
pushed a commit
to PhysSong/lmms
that referenced
this pull request
Jul 8, 2017
We give the stream a unique serial number and make sure it isn't '0' or 'UINT_32_MAX'. Change obsolete 'Linux MultiMedia Studio' to 'LMMS' in ogg file comment.
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
We give the stream a unique serial number and make sure it isn't '0' or 'UINT_32_MAX'. Change obsolete 'Linux MultiMedia Studio' to 'LMMS' in ogg file comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We set the serial number on our generated Ogg files to 0 but it's supposed to be a unique number.
Furthermore
0 and UINT_32_MAXare to be avoided for some reason and that's what the message is about. Better give it some good numbers... :)The documentation and code comments use
intanduint32_tinterchangeably anduint32_twas what we used previously so it should be fine.Also, we stick the obsolete Linux Multimedia Studio to the end of the exported file. I change that to LMMS.
Fixed serial number (serial: faf21bb8) and message is updated.