Rename Beat/Bassline editor to Pattern editor #2974
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good 👌 |
|
I don't feel comfortable doing this change so superficially, this takes extensive planning and I want to rename the underlying code as well, but further discussion is needed to define all the names for the elements we have in software. Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #120.
This PR solves the problem on a superficial level, affecting only the gui. I will try to make a PR that will do the name change on the code level.
Now, I added an part in the upgrade that replaces 'Beat/Bassline' with 'Pattern'. I also made this change to necessary built in projects.
Testing welcome, please let me know If I missed something.