Re organizing of the user LMMS directory #1908
Conversation
Wrapped the path selection widgets in a Scroll Area, to allow for the addition of addition paths. Where multipue paths are allowed the icon has been changed to refect this. Reordered the list.
Added option to set gig folder in setup dialog Gig player now opens at this location
added add_folder.png icon to use for adding addition folders. this may need attention by others changed layout to correctly display scroll bar
added a default path for sf create folder add folder to setup dialog sf player now uses this location
the user vst folder nowbecome the default vstfolder. this is configurable in the setup dialog. The user ladspa folder is added to the list of folder to search
| @@ -425,6 +441,11 @@ void ConfigManager::loadConfigFile() | |||
| QDir().mkpath( userProjectsDir() ); | |||
| QDir().mkpath( userSamplesDir() ); | |||
| QDir().mkpath( userPresetsDir() ); | |||
| QDir().mkpath( userGigDir() ); | |||
| QDir().mkpath( userSf2Dir() ); | |||
| QDir().mkpath( vstDir() ); | |||
There was a problem hiding this comment.
Noticed the naming convention of this vstDir() vs. usersVstDir()... also many Windows users historically have the vstDir() set to a restricted area (such as Program Files/Steinberg/). Does mkpath(...) fail silently if the area can't be written to?
There was a problem hiding this comment.
The directories are only created once, so there will be a user Lmms/plugin/vst folder created when the the user lmms folder in initially created.
If/ when the user sets it to another location ie Program Files/Steinberg/ no attempt is made to create or write to that location.
There was a problem hiding this comment.
If/ when the user sets it to another location ie Program Files/Steinberg/ no attempt is made to create or write to that location.
Ok. :)
|
This isn't your fault, but we have some naming convention conflicts in our code, i.e. -Tres |
|
@curlymorphic this is great. Since it is a significant change, I want a few set of eyes before merging it. @badosu, @lukas-w any objections? |
will have a look at this later today |
Added a userVstDir function for consistancy use the userVstDir() function to create new folder
Added |
|
Wait, where do "actual" (wav) samples go in this? It seems they go under
samples, but we also have subfolders there. This looks like it could get
pretty messy to me. Maybe there ought to be a subfolder specifially for
audio samples as well? Sorry if I'm late to the discussion.
|
Yes, samples. |
Most people already put them in subfolders, you may be overthinking this.. |
|
@tresf I know most people put their samples in subfolders, so do I. It just
feels unorganized to me to have multiple sample pack folders and the gig
and sf2 folders together.
|
|
Then don't. What do you propose? |
I agree, we have to be careful to still give users there freedom. |
|
Samples/audio? I would have proposed:
Song
_Projects
_Templates
Sound
_Gig
_Sf
_Samples
_Ladspa
_VST
___Instruments
___Effects
Themes
|
|
Nah, leave it. SF2 and GIG was decided as samples. Samples is audio, no difference :) |
|
Merging per organization feedback and researching #1807. 👍 Updated release notes:
If we encounter issues, we'll open new bugs. :) |
Re organizing of the user LMMS directory
Have updated the users LMMS directory to contain the following folders
Added the extra folders to the settings dialog , Added a Scroll area to the dialog to allow the extra space needed.
Updated the icon where multiple Folders are allowed.
ArtWork renamed to themes
Opening of correct folders where needed, SF2 player opens the sf folder, GIG player opens the gig folder.
fixes #1807