Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed fix 1634 Allow drag-and-drop of project files #1668

Merged
merged 1 commit into from
Jan 21, 2015
Merged

Proposed fix 1634 Allow drag-and-drop of project files #1668

merged 1 commit into from
Jan 21, 2015

Conversation

curlymorphic
Copy link
Contributor

Proposed fix #1634 Allow drag-and-drop of project files

@tresf
Copy link
Member

tresf commented Jan 21, 2015

Looks good. Thanks for implementing this!

I assume this inherently checks that the project hasn't been modified same as the double-click behavior. Merging.

tresf added a commit that referenced this pull request Jan 21, 2015
Proposed fix 1643 Allow drag-and-drop of project files
@tresf tresf merged commit 9b26c5b into LMMS:master Jan 21, 2015
@lukas-w
Copy link
Member

lukas-w commented Jan 22, 2015

I assume this inherently checks that the project hasn't been modified

It looks like it doesn't.

@tresf
Copy link
Member

tresf commented Jan 22, 2015

@curlymorphic can you shim in a project modification check? This way the drag-and-drop doesn't bypass the "Do you want to save settings" dialog. 👍

@tresf
Copy link
Member

tresf commented Jan 22, 2015

P.S. @lukas-w thanks for checking.

@curlymorphic
Copy link
Contributor Author

@curlymorphic can you shim in a project modification check? This way the drag-and-drop doesn't bypass the "Do you want to save settings" dialog.

yes. I am taking a look now.

@lukas-w
Copy link
Member

lukas-w commented Jan 22, 2015

@curlymorphic You'll probably want to use bool MainWindow::mayChangeProject();

@curlymorphic
Copy link
Contributor Author

You'll probably want to use bool MainWindow::mayChangeProject();

:) has taken a few for me to work out its not static so needs an instance, but seems to be working now. Just testing it now.

@curlymorphic curlymorphic changed the title Proposed fix 1643 Allow drag-and-drop of project files Proposed fix 1634 Allow drag-and-drop of project files Jan 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants