Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Piano Roll Key Press #8

Closed
bhattigurjot opened this issue Jan 11, 2014 · 6 comments
Closed

Piano Roll Key Press #8

bhattigurjot opened this issue Jan 11, 2014 · 6 comments

Comments

@bhattigurjot
Copy link
Contributor

While using Piano Roll, we can play the notes using either of the 3
following methods.

  1. From our computer Keyboard.
  2. From MIDI Keyboard.
  3. Directly using left mouse button.

The notes are played but no visual information is displayed regarding
the key-presses unlike Piano View of our Instrument Settings. In
there, the key press is visible.
This feature is quite useful to the users who are placing the notes in
the Piano Roll while playing them.
And it seems that it has not been implemented in LMMS even though there are images of key presses available in the default theme.

Edit: The whole row of the playing note/key should be highlighted instead of just showing the current key press.

@SadaleNet
Copy link
Contributor

How about highlighting the whole row in the piano roll when the note is being played? Wouldn't this make it even easier to place notes?

@bhattigurjot
Copy link
Contributor Author

Yeah it would certainly.
FL Studio also uses the same.
Actually I was thinking along the same line just forgot to add the 'row' bit in this. :)
I'll edit the issue.

@SadaleNet
Copy link
Contributor

I guess you are going to implement this, right? If so, it's better to let other know in the post above to prevent duplicate implementation.

@bhattigurjot
Copy link
Contributor Author

Actually only the admins or contributors here can assign the issue to someone. I'm waiting for the senior members' response. Toby will decide in the end.

@tobydox
Copy link
Member

tobydox commented Jan 12, 2014

I missed that feature too - any volunteers for implementation are welcome :-)

@bhattigurjot
Copy link
Contributor Author

I'm ready. Already started discussing on the mailing list. :)

tresf pushed a commit that referenced this issue Dec 17, 2014
allejok96 pushed a commit to allejok96/lmms that referenced this issue Oct 3, 2021
* Separate drag/click actions

* Simplify mouse binding mechanism, only show help text on drag

* Variables holding enums

* Default to NoAction
PhysSong pushed a commit that referenced this issue Feb 3, 2022
* fea) ui resource 및 스타일코드 수정

리소스 그림 파일 추가
스타일 코드 수정

* fix)LMMS 미디 파일 범위 수정

master 브랜치의 PR내용을 수정하여 적용하였음
(윈도우 서버에서 테스트 필요)

https://github.com/LMMS/lmms/pull/5868/files?authenticity_token=GAlDaXqic5oivSbNMldhVqg5n4cS4v142RNC0W53nnhls6uPWcLCMRImhn2Dr3bniCFQdLD8vjspJZil6XMxUw%3D%3D&file-filters%5B%5D=.cpp&file-filters%5B%5D=.png

* doc) gitignore 수정

.vscode 저장소에서 삭제
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants