Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden components under part of the main GUI #765

Open
Tracked by #6376
musikBear opened this issue May 24, 2014 · 7 comments
Open
Tracked by #6376

Hidden components under part of the main GUI #765

musikBear opened this issue May 24, 2014 · 7 comments

Comments

@musikBear
Copy link

OS win 32 XP
ver 1.0.2
In some circumstances it is not possible to scroll the main-window, so elements that are hidden under the main-top-bar, can be reached with the mouse.
In this picture
http://snag.gy/1liQn.jpg
two windows are opend, the songeditor, and one instrument.
Leftmost: Song-editor is maximized. The slider is in max-pos, but most of the instrument is hidden under the main-top.
Middle: Song-editor is 'floating'. The slider jumps to a new pos, leaving room for additionel scrolling.
Right: The instrument is fully visible, after the scroll-slider is moved to 'new' max-pos.
It is not good that a window can get hidden, if the workspace is maximized (eg leftmost situation)

@tresf
Copy link
Member

tresf commented Jun 12, 2014

I experience this often and sometimes loading a project after the software has been loaded. I've assumed they're bugs with QMdiArea but they are too unpredictable to know for sure.

If someone can make this bug reproducible with a series of steps it is much more likely it can be traced to a bug with the software.

@musikBear
Copy link
Author

If someone can make this bug reproducible with a series of steps it is much more likely it can be traced to a bug

:/ have been shufling presets and windows for bout hour .. cant find a way to make it happen .. could be a special seqence of open/ close specific windows, that induce it, but the permutation are enourmous ..still trying ..
o-----------o------------o
think i partly got it - it happens if a componet has been maximized, but it also need the problem component to closed and then reopend -It then reopen outside ..sometimes
But more important, i have the solution- If the main GUI has the focus up/dn does not do anything (same for pgUp/dn btw) -So these keys are 'free' to be connected to a 'always scroll all to resp. min and max posistions'. IF that is doable(??), then it means squad whats actually induces it - that would be transparent, because up/dn simply eradicate it. Think this is for 1.1, because its a anoying bug

@Umcaruje
Copy link
Member

Reproduced on current master - ubuntu 15.04 x64

Steps to reproduce:

  • Open new project
  • Maximize the song editor
  • Open the TripleOscillator
  • Move the TripleOscillator outside the main view
  • Click back on the Song editor so it gains focus
  • Open TripleOscillator again, it now can't be moved.

Here is a gif of the behavior:
gifrecord_2015-06-30_124032

@Veratil
Copy link
Contributor

Veratil commented Apr 13, 2020

It looks like a simple solution would be to check the window when show()ing if its y position is < 0.
Adding this to InstrumentTrack.cpp's InstrumentTrackView::toggleVisibility makes it so the window always moves to 0 if it was moved "above" the top of the MdiArea.

if (parentWidget()->pos().y() < 0)
{
    parentWidget()->move(parentWidget()->pos().x(), 0);
}

I don't know if this is always acceptable, as if you scroll down and have windows hidden above from scrolling then it will also be put to "0".

@tresf
Copy link
Member

tresf commented Apr 14, 2020

The issue is caused by a maximized song editor window and the only real bug is that the scroll bar vanishes. If you un-maximize the song editor window, the scroll bar comes back as it should. I believe the underlying issue has more to do with the fact that the MDI area can't handle a maximized window and a non-maximizable window.

Bumping the y-coord to zero is fine as long as we aren't mucking with any regular workflow. Perhaps, we start by doing it only when there's a maximized window to alleviate any oddball workspace side-effects of this.

@tresf
Copy link
Member

tresf commented Apr 14, 2020

In action:
ezgif-2-6172a7e30690

@PhysSong
Copy link
Member

the only real bug is that the scroll bar vanishes.

Sounds similar to a bug which was fixed in cc1cdfa. I can't find the original Qt bug report, but it seems like that hasn't been fixed yet.
BTW, I found one more case when editing the detuning of a note in the piano-roll.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants