Bitcrush plugins displays output clip level as % while it's dBFS

[PhysSong]

See the code below:

lmms/plugins/Bitcrush/Bitcrush.cpp

Lines 141 to 144 in eeec3f8

	if( m_needsUpdate || m_controls.m_outClip.isValueChanged() )
	{
	m_outClip = dbfsToAmp( m_controls.m_outClip.value() );
	}

lmms/plugins/Bitcrush/BitcrushControlDialog.cpp

Lines 77 to 78 in eeec3f8

	outClip->setLabel( tr( "CLIP" ) );
	outClip->setHintText( tr( "Output clip:" ) , "%" );

[deenadayalancs]

Hello @PhysSong ,

Can i replace % with dBFS and push this code?

This is my first github contribution.

lmms/plugins/Bitcrush/BitcrushControlDialog.cpp

outClip->setHintText( tr( "Output clip:" ) , " dBFS");

Thanks,
Deena

[PhysSong]

Are you familiar with Git and GitHub? If not, here are the simple steps for changing only one file:

• Go to https://github.com/LMMS/lmms/blob/master/plugins/Bitcrush/BitcrushControlDialog.cpp and click the edit button(the pencil button)
• Edit the file and then click the "Propose changes" button
• Submit a pull request

If you want to contribute further, please make sure you're familiar with them!

[PhysSong]

@deenadayalancs Now you can go master...deenadayalancs:patch-1 and create a pull request. 👍