Crash when previewing sample #5736
Comments
|
#5427 is suspect, I suppose, but I can't say I know why it would cause this to start happening. One thing I find suspicious is that the mixer seems to act as if it owns play handles added via
|
|
Yes. It looks like #5427 is the cause of this. I can't make lmms crash like this in the commit prior to this one. |
|
A more precise method to replicate this is.
|
|
Marking for 1.3 since it's a regression, but I'd love thoughts on the options above before I try to tackle this. I'm not particularly familiar with pointers. |
|
I got the following output with Valgrind: Click to expand#5736 (comment) seems to make sense according to the output. |
|
So, does |
|
I will try reverting #5427 locally and check if the same error existed before. |
|
I could get a similar error, but very rarely. It seems like an underlying issue has been there for a long time. |
|
Found a much more reliable way to trigger the bug:
|
|
|
Adding Also, I feel like I should add
|
|
That's quite complicated. I think a number of functions in |
Doing so leads to several overlapping sample previews if you preview a new sample while an old one is auto-playing, so I wouldn't consider it a real fix. What about removing the logic that makes samples keep playing after mouse release? It's not really a fix either, but until I looked at this code I never really understood why samples sometimes stopped their preview and sonetines didn't. To me it's not particularly useful or intuitive, but I suppose it'd be good to get more opinions on this. |
Less than ideal, but should close #5736.
|
After some discussion in Discord, it's been decided that a new tag should be made once this is fixed. Discussion summary (hopefully accurate):
|
|
Question: LMMS currently removes all |
|
With the current state of our stop button I don't think it should. If we had a "silence everything" function it should stop previews IMO, but the stop button doesn't do that right now (it allows reverbs, note releases, and similar things to keep going). |
Got a crash when previewing a sample when running lmms in gdb.
-DCMAKE_BUILD_TYPE=Debug -DWANT_DEBUG_FPE=Truelmms version - master, 7808e0b with one unrelated commit on top.
Method to replicate
Logs
Click to expand
Thread 1 "lmms" received signal SIGSEGV, Segmentation fault. 0x00005555557b305f in Mixer::removePlayHandle (this=0x555555c920c0, _ph=0x55555a4d34f0) at /home/zonkmachine/builds/lmms/src/core/Mixer.cpp:705 705 if( _ph->affinityMatters() && (gdb) bt #0 0x00005555557b305f in Mixer::removePlayHandle(PlayHandle*) (this=0x555555c920c0, _ph=0x55555a4d34f0) at /home/zonkmachine/builds/lmms/src/core/Mixer.cpp:705 #1 0x000055555586a7f9 in FileBrowserTreeWidget::stopPreview() (this=0x5555598e4650) at /home/zonkmachine/builds/lmms/src/gui/FileBrowser.cpp:607 #2 0x000055555586a13b in FileBrowserTreeWidget::previewFileItem(FileItem*) (this=0x5555598e4650, file=0x555559911170) at /home/zonkmachine/builds/lmms/src/gui/FileBrowser.cpp:543 #3 0x000055555586a0c2 in FileBrowserTreeWidget::mousePressEvent(QMouseEvent*) (this=0x5555598e4650, me=0x7fffffffd3e0) at /home/zonkmachine/builds/lmms/src/gui/FileBrowser.cpp:532 #4 0x00007ffff7a972d1 in QWidget::event(QEvent*) (this=this@entry=0x5555598e4650, event=event@entry=0x7fffffffd3e0) at kernel/qwidget.cpp:8959 #5 0x00007ffff7b44d52 in QFrame::event(QEvent*) (this=0x5555598e4650, e=0x7fffffffd3e0) at widgets/qframe.cpp:550 #6 0x00007ffff7cc9482 in QAbstractItemView::viewportEvent(QEvent*) (this=this@entry=0x5555598e4650, event=event@entry=0x7fffffffd3e0) at itemviews/qabstractitemview.cpp:1750 #7 0x00007ffff7d3762f in QTreeView::viewportEvent(QEvent*) (this=0x5555598e4650, event=0x7fffffffd3e0) at itemviews/qtreeview.cpp:1318 #8 0x00007ffff66e664b in QCoreApplicationPrivate::sendThroughObjectEventFilters(QObject*, QEvent*) (event=, receiver=) at kernel/qcoreapplication.cpp:1214 #9 QCoreApplicationPrivate::sendThroughObjectEventFilters(QObject*, QEvent*) (receiver=receiver@entry=0x5555598f3850, event=event@entry=0x7fffffffd3e0) at kernel/qcoreapplication.cpp:1203 #10 0x00007ffff7a54a55 in QApplicationPrivate::notify_helper(QObject*, QEvent*) (this=this@entry=0x555555b12f70, receiver=receiver@entry=0x5555598f3850, e=e@entry=0x7fffffffd3e0) at kernel/qapplication.cpp:3694 #11 0x00007ffff7a5e343 in QApplication::notify(QObject*, QEvent*) (this=, receiver=0x5555598f3850, e=0x7fffffffd3e0) at kernel/qapplication.cpp:3160 #12 0x00007ffff66e693a in QCoreApplication::notifyInternal2(QObject*, QEvent*) (receiver=0x5555598f3850, event=0x7fffffffd3e0) at ../../include/QtCore/../../src/corelib/kernel/qobject.h:142 #13 0x00007ffff7a5d457 in QApplicationPrivate::sendMouseEvent(QWidget*, QMouseEvent*, QWidget*, QWidget*, QWidget**, QPointer&, bool, bool) (receiver=receiver@entry=0x5555598f3850, event=event@entry=0x7fffffffd3e0, alienWidget=alienWidget@entry=0x5555598f3850, nativeWidget=0x555559501330, buttonDown=buttonDown@entry=0x7ffff7f848d0 , lastMouseReceiver=..., spontaneous=true, onlyDispatchEnterLeave=false) at kernel/qapplication.cpp:2646 #14 0x00007ffff7ab335d in QWidgetWindow::handleMouseEvent(QMouseEvent*) (this=0x555559e13700, event=0x7fffffffd860) at /usr/include/c++/9/bits/atomic_base.h:413 #15 0x00007ffff7ab61ec in QWidgetWindow::event(QEvent*) (event=0x7fffffffd860, this=0x555559e13700) at kernel/qwidgetwindow.cpp:289 #16 QWidgetWindow::event(QEvent*) (this=0x555559e13700, event=0x7fffffffd860) at kernel/qwidgetwindow.cpp:232 #17 0x00007ffff7a54a66 in QApplicationPrivate::notify_helper(QObject*, QEvent*) (this=this@entry=0x555555b12f70, receiver=receiver@entry=0x555559e13700, e=e@entry=0x7fffffffd860) at kernel/qapplication.cpp:3700 #18 0x00007ffff7a5e0f0 in QApplication::notify(QObject*, QEvent*) (this=0x555555b12f50, receiver=0x555559e13700, e=0x7fffffffd860) at kernel/qapplication.cpp:3446 #19 0x00007ffff66e693a in QCoreApplication::notifyInternal2(QObject*, QEvent*) (receiver=0x555559e13700, event=0x7fffffffd860) at ../../include/QtCore/../../src/corelib/kernel/qobject.h:142 #20 0x00007ffff6acf7d3 in QGuiApplicationPrivate::processMouseEvent(QWindowSystemInterfacePrivate::MouseEvent*) (e=e@entry=0x55555a818520) at kernel/qguiapplication.cpp:2107 #21 0x00007ffff6ad110b in QGuiApplicationPrivate::processWindowSystemEvent(QWindowSystemInterfacePrivate::WindowSystemEvent*) (e=e@entry=0x55555a818520) at kernel/qguiapplication.cpp:1842 #22 0x00007ffff6aab35b in QWindowSystemInterface::sendWindowSystemEvents(QFlags) (flags=flags@entry=...) at kernel/qwindowsysteminterface.cpp:1151 #23 0x00007ffff214032e in xcbSourceDispatch(GSource*, GSourceFunc, gpointer) (source=) at qxcbeventdispatcher.cpp:105 #24 0x00007ffff5455fbd in g_main_context_dispatch () at /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0 #25 0x00007ffff5456240 in () at /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0 #26 0x00007ffff54562e3 in g_main_context_iteration () at /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0 #27 0x00007ffff673e565 in QEventDispatcherGlib::processEvents(QFlags) (this=0x555555bcd490, flags=...) at kernel/qeventdispatcher_glib.cpp:422 #28 0x00007ffff66e54db in QEventLoop::exec(QFlags) (this=this@entry=0x7fffffffdc00, flags=..., flags@entry=...) at ../../include/QtCore/../../src/corelib/global/qflags.h:140 #29 0x00007ffff66ed246 in QCoreApplication::exec() () at ../../include/QtCore/../../src/corelib/global/qflags.h:120 #30 0x000055555571bbd4 in main(int, char**) (argc=1, argv=0x7fffffffdf78) at /home/zonkmachine/builds/lmms/src/core/main.cpp:991 (gdb) bt full #0 0x00005555557b305f in Mixer::removePlayHandle(PlayHandle*) (this=0x555555c920c0, _ph=0x55555a4d34f0) at /home/zonkmachine/builds/lmms/src/core/Mixer.cpp:705 #1 0x000055555586a7f9 in FileBrowserTreeWidget::stopPreview() (this=0x5555598e4650) at /home/zonkmachine/builds/lmms/src/gui/FileBrowser.cpp:607 previewLocker = {val = 93825063077529} #2 0x000055555586a13b in FileBrowserTreeWidget::previewFileItem(FileItem*) (this=0x5555598e4650, file=0x555559911170) at /home/zonkmachine/builds/lmms/src/gui/FileBrowser.cpp:543 previewLocker = {val = 93825063077529} newPPH = 0x5555598f1a30 fileName = {static null = {}, d = 0x7fffffffcc40} ext = {static null = {}, d = 0x555559911170} #3 0x000055555586a0c2 in FileBrowserTreeWidget::mousePressEvent(QMouseEvent*) (this=0x5555598e4650, me=0x7fffffffd3e0) at /home/zonkmachine/builds/lmms/src/gui/FileBrowser.cpp:532 i = 0x555559911170 f = 0x555559911170 #4 0x00007ffff7a972d1 in QWidget::event(QEvent*) (this=this@entry=0x5555598e4650, event=event@entry=0x7fffffffd3e0) at kernel/qwidget.cpp:8959 d = 0x5555598f1a30 #5 0x00007ffff7b44d52 in QFrame::event(QEvent*) (this=0x5555598e4650, e=0x7fffffffd3e0) at widgets/qframe.cpp:550 result = #6 0x00007ffff7cc9482 in QAbstractItemView::viewportEvent(QEvent*) (this=this@entry=0x5555598e4650, event=event@entry=0x7fffffffd3e0) at itemviews/qabstractitemview.cpp:1750 d = #7 0x00007ffff7d3762f in QTreeView::viewportEvent(QEvent*) (this=0x5555598e4650, event=0x7fffffffd3e0) at itemviews/qtreeview.cpp:1318 d = #8 0x00007ffff66e664b in QCoreApplicationPrivate::sendThroughObjectEventFilters(QObject*, QEvent*) (event=, receiver=) at kernel/qcoreapplication.cpp:1214 obj = i = 0 #9 QCoreApplicationPrivate::sendThroughObjectEventFilters(QObject*, QEvent*) (receiver=receiver@entry=0x5555598f3850, event=event@entry=0x7fffffffd3e0) at kernel/qcoreapplication.cpp:1203 #10 0x00007ffff7a54a55 in QApplicationPrivate::notify_helper(QObject*, QEvent*) (this=this@entry=0x555555b12f70, receiver=receiver@entry=0x5555598f3850, e=e@entry=0x7fffffffd3e0) at kernel/qapplication.cpp:3694 consumed = false filtered = false #11 0x00007ffff7a5e343 in QApplication::notify(QObject*, QEvent*) (this=, receiver=0x5555598f3850, e=0x7fffffffd3e0) at kernel/qapplication.cpp:3160 me = { = { = {_vptr.QEvent = 0x7ffff6f7d200 , static staticMetaObject = {d = {superdata = 0x0, stringdata = 0x7ffff688cde0 , data = 0x7ffff688c820 , static_metacall = 0x0, relatedMetaObjects = 0x0, extradata = 0x0}}, d = 0x0, t = 2, posted = 0, spont = 1, m_accept = 1, reserved = 2876}, modState = {i = 0}, ts = 5706568}, l = {xp = 136, yp = 567}, w = {xp = 172, yp = 728}, s = {xp = 172, yp = 751}, b = Qt::LeftButton, mouseState = {i = 1}, caps = 0, velocity = {v = {0, 0}}} w = 0x5555598f3850 mouse = 0x7fffffffd3e0 eventAccepted = relpos = {xp = 136, yp = 567} pw = {wp = {d = 0x55555a48a690, value = 0x5555598f3850}} d = res = false #12 0x00007ffff66e693a in QCoreApplication::notifyInternal2(QObject*, QEvent*) (receiver=0x5555598f3850, event=0x7fffffffd3e0) at ../../include/QtCore/../../src/corelib/kernel/qobject.h:142 selfRequired = true result = false cbdata = {0x5555598f3850, 0x7fffffffd3e0, 0x7fffffffd1df} --Type for more, q to quit, c to continue without paging--c d = threadData = 0x555555b130f0 scopeLevelCounter = {threadData = 0x555555b130f0} #13 0x00007ffff7a5d457 in QApplicationPrivate::sendMouseEvent(QWidget*, QMouseEvent*, QWidget*, QWidget*, QWidget**, QPointer&, bool, bool) (receiver=receiver@entry=0x5555598f3850, event=event@entry=0x7fffffffd3e0, alienWidget=alienWidget@entry=0x5555598f3850, nativeWidget=0x555559501330, buttonDown=buttonDown@entry=0x7ffff7f848d0 , lastMouseReceiver=..., spontaneous=true, onlyDispatchEnterLeave=false) at kernel/qapplication.cpp:2646 graphicsWidget = false widgetUnderMouse = wasLeaveAfterRelease = true result = true #14 0x00007ffff7ab335d in QWidgetWindow::handleMouseEvent(QMouseEvent*) (this=0x555559e13700, event=0x7fffffffd860) at /usr/include/c++/9/bits/atomic_base.h:413 translated = { = { = {_vptr.QEvent = 0x7ffff6f7d200 , static staticMetaObject = {d = {superdata = 0x0, stringdata = 0x7ffff688cde0 , data = 0x7ffff688c820 , static_metacall = 0x0, relatedMetaObjects = 0x0, extradata = 0x0}}, d = 0x0, t = 2, posted = 0, spont = 1, m_accept = 1, reserved = 2870}, modState = {i = 0}, ts = 5706568}, l = {xp = 136, yp = 567}, w = {xp = 172, yp = 728}, s = {xp = 172, yp = 751}, b = Qt::LeftButton, mouseState = {i = 1}, caps = 0, velocity = {v = {0, 0}}} contextMenuTrigger = QEvent::MouseButtonPress widget = 0x5555598f3850 mapped = {xp = 136, yp = 567} initialPress = receiver = 0x5555598f3850Edit: method to replicate issue updated
The text was updated successfully, but these errors were encountered: