Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppImage has Travis-CI paths #5187

Closed
tresf opened this issue Sep 15, 2019 · 2 comments
Closed

AppImage has Travis-CI paths #5187

tresf opened this issue Sep 15, 2019 · 2 comments
Assignees
Labels

Comments

@tresf
Copy link
Member

tresf commented Sep 15, 2019

The AppImage's AppRun has some paths added that are benign but shouldn't be there, probably due to improper immediate variable expansion.

Most of these are benign because they'll never exist on a machine, but some, such as /opt/qt59/bin can cause issues, since the AppImage should prefer the Qt5 that it ships with.

export PATH="\
/home/travis/build/PhysSong/lmms/build/cmake/linux/squashfs-root/usr/bin:\
/opt/qt59/bin:\
/opt/qt59/bin:\
/home/travis/.rvm/gems/ruby-2.4.1/bin:\
/home/travis/.rvm/gems/ruby-2.4.1@global/bin:\
/home/travis/.rvm/rubies/ruby-2.4.1/bin:\
/home/travis/.rvm/bin:\
/home/travis/bin:\
/home/travis/.local/bin:\
/opt/pyenv/shims:\
/home/travis/.phpenv/shims:\
/home/travis/perl5/perlbrew/bin:
/home/travis/.nvm/versions/node/v8.9.1/bin:\
/home/travis/.kiex/elixirs/elixir-1.4.5/bin:\
/home/travis/.kiex/bin:\
/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.7.4.linux.amd64/bin:\
/usr/local/phantomjs/bin:/usr/local/phantomjs:\
/usr/local/neo4j-3.2.7/bin:/usr/local/maven-3.5.2/bin:/usr/local/cmake-3.9.2/bin:\
/usr/local/clang-5.0.0/bin:\
/usr/local/sbin:\
/usr/local/bin:\
/usr/sbin:/usr/bin:\
/sbin:\
/bin:\
/home/travis/.phpenv/bin:\
/opt/pyenv/bin:\
/home/travis/.yarn/bin:\
/sbin"
@tresf tresf added the bug label Sep 15, 2019
@PhysSong
Copy link
Member

export PATH="$PATH:/sbin"

I think it should be export PATH="\$PATH:/sbin".

@tresf tresf closed this as completed in ffa03df Sep 15, 2019
@tresf
Copy link
Member Author

tresf commented Sep 15, 2019

I've committed the patch directly to master. If it causes major issues, we can cherry-pick it to stable-1.2.

sdasda7777 pushed a commit to sdasda7777/lmms that referenced this issue Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants