Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better metronome #475

Open
1 of 2 tasks
musikBear opened this issue Mar 17, 2014 · 16 comments
Open
1 of 2 tasks

Better metronome #475

musikBear opened this issue Mar 17, 2014 · 16 comments

Comments

@musikBear
Copy link

musikBear commented Mar 17, 2014

I think the metronome is of low quality. Several has asked for ways to shut it of, all together.. (whitch easy btw) -to me that idicate an area where something new is needed.
At least a two-effect metronome (eg tttToc ttt Toc) with a clear difference on-beat, but perhaps more. Why not let the user set volume and perhaps a selection of sounds?

In the more exotic department (craaazy:P) I wonder if metronome could be a usefull tool
in live record -How about a time-delayed feature. -Eg a metronome that could be set to a precise off-value. this would let the user listen for the toc, and then have able time to do a note event. Depending of Q-setting and perhaps even HW reaction-delay, this could aid the use, in a creative fashion? -Also a 'beat-counting' feature could be implemented with a variable metronome. The user then turn the dial untill the ticks fits the played music - a display shows current BPM. -just some thoughts in respet to a somewhat disliked feature.


@lazerblade
Copy link

I like the idea of having a setting option to shut it off, and of having an off beat and a way to control volume. Once you start going past that though, it starts to be something that is so variable that users could just as easily build a beat to play to rather than tweaking all of the settings needed to make the metronome act in a beat's place just the way they want.

@eagles051387
Copy link

A metronome would be very useful when you are wanting to practise a melody
before recording it using a midi keyboard. I use it quite a bit in Logic
Pro X

On Mon, Mar 17, 2014 at 1:44 PM, musikBear notifications@github.com wrote:

I think the metronome is og low quality. several has asked for ways to
shut it of, all together.. (whitch easy btw) -to me that idicate an area
where something new is needed.
At least a two-effect metronome (eg tttToc ttt Toc) with a clear
difference on-beat, but perhaps more. Why not let the user set volume and
perhaps a selection of sounds?

In the more exotic department (craaazy:P) I wonder if metronome could be a
usefull tool
in live record -How about a time-delayed feature. -Eg a metronome that
could be set to a precise off-value. this would let the user listen for the
toc, and then have able time to do a note event. Depending of Q-setting and
perhaps even HW reaction-delay, this could aid the use, in a creative
fashion? -Also a 'beat-counting' feature could be implemented with a
variable metronome. The user then turn the dial untill the ticks fits the
played music - a display shows current BPM. -just some thoughts in respet
to a somewhat disliked feature.

Reply to this email directly or view it on GitHubhttps://github.com//issues/475
.

Jonathan Aquilina

@musikBear
Copy link
Author

ref #869

@Umcaruje Umcaruje added the ux label Jun 27, 2015
@Umcaruje Umcaruje changed the title Enhancement: Better metronome Better metronome Jun 27, 2015
@zonkmachine
Copy link
Member

zonkmachine commented Jul 14, 2015

I'm looking into this. At a bare minimum I'll fix an on/off button and a setting to switch it default on/off.
Edit: Nope...

@Moth-Tolias
Copy link

Being able to set an offset would be of valuable assistance when dealing with latency.

@frank-a-i
Copy link
Contributor

I just had a look into the aspect of the metronome's volume control. I find it a little too much to open up a new (maybe hidden) channel in the mixer just for the metronome, however I couldn't think of anything else less code invasive, then again I just have started with LMMS'Code. Do you think going over the mixer would be the right way?

@musikBear
Copy link
Author

@the-bebop metronome-volume could be regarded as a similar issue as prehear-volume
image
Both are atm not controllable.
I think something like right click could make a slider appear.
Is there a property for the volume at all? -And if so -in witch class?

@Spekular
Copy link
Member

Spekular commented Jul 26, 2021

Reference

Ableton uses a combobox/button combo (we have a similar one in piano roll for quantization) to expose additional metronome options.
image

FL Studio lets you choose metronome type by right clicking the metronome enable button.
image

@Spekular
Copy link
Member

If we want to start adding a lot of options, I think a separate pane (like the controller rack, project notes, etc.) would be suitable. Then we could have excessive customization like adjustable volume, pitch and sample selection for first and remaining hits, etc.

Otherwise, I think we should use a dropdown style menu (like Ableton) that provides preset volume levels (100/75/50/25%).

@frank-a-i
Copy link
Contributor

Interesting ideas I like a lot, if we go the Ableton way, one might also add the volume slider in that drop down menu. About the volume settings, I'll have a look into the backend later on and see if we really need a new volume feature

@Monospace-V
Copy link
Contributor

The metronome tends to skip beats on high tempos. Will this enhancement cater to that too, or only improve metronome's power?

@frank-a-i
Copy link
Contributor

The metronome tends to skip beats on high tempos. Will this enhancement cater to that too, or only improve metronome's power?

Oh never noticed that. Looks like a differnt issue to me, as this seems scheduling related at first glance.

@frank-a-i
Copy link
Contributor

frank-a-i commented Jul 27, 2021

About the volume: I had a look and particularly for the metronome, SamplePlayHandle solely needs to forward amplification to SampleBuffer, with its usage in SampleBuffer::play, which would introduce a sample-based volume control that should be defaulted for the general use case so anything else would stay untouched. Eventually this would be integrated around addPlayHandle() in Mixer::handleMetronome() if you're curious

If there are no objections with that approach, I would:

  • implemented it that way in the backend
  • go with the dropdown menu design (see Ableton screenshot from @Spekular) with (currently) only option to specify the frequency and enhance it with a volume slider for the frontend

@musikBear
Copy link
Author

Looks like a differnt issue to me

It is -afair it is also fixed

@zonkmachine
Copy link
Member

Looks like a differnt issue to me

It is -afair it is also fixed

It's not fixed. #4038

@frank-a-i
Copy link
Contributor

The metronome tends to skip beats on high tempos. Will this enhancement cater to that too, or only improve metronome's power?

Possible fix #6149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests