@ PGib , song editor graphics.

[mikobuntu]

Hi Paul, i can remember some time ago i believe you had hard coded new graphics for the "blocks" into the song_editor. they had curved corners and a gradient. I think these would look great for the next release, i cant seem to find them at the moment tho to show the other devs, and i could prob dig out my CSS manual and have a go at doing them, but it would be easier if you still had the code..

thanks Mikobuntu :)

[unfa]

If it is what I think it is then it would really greatly boost the visual
changes.

2014-01-25 mikobuntu notifications@github.com

Hi Paul, i can remember some time ago i believe you had hard coded new
graphics for the "blocks" into the song_editor. they had curved corners and
a gradient. I think these would look great for the next release, i cant
seem to find them at the moment tho to show the other devs, and i could
prob dig out my CSS manual and have a go at doing them, but it would be
easier if you still had the code..

thanks Mikobuntu :)

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/150
.

Tobiasz unfa

-----BEGIN GEEK CODE BLOCK-----
Version: 3.1
GIT/MU/P d->-- s+:-(--)> a? C++(+++)>$ ULC+(++)>$ !P? L+++>++++$ E? W++>$
!N-? !o--? K-? !w-- O? !M-- V? PS++ PE++ !Y+ !PGP+? !t(+) 5? !X !R+ tv
b+>+++ DI>+ D+ G e h-->- !r y--()
------END GEEK CODE BLOCK------

[Sti2nd]

Just tagging pgib @pgiblox

[pgiblock]

Yeah. They are around. I'll dig up the commits

[mikobuntu]

brilliant Pgib :)

[pgiblock]

Alright, I found the code, it is part of the CusisStyle. Part of the code features the ability to load a different style at runtime (was originally "Classic" versus "Cusis"). I wonder if this switching logic will still be useful? Or should I just merge the code into the current LmmsStyle. I guess we can always add the switching later to let users use the "classic" or newer alternative styles.

[pgiblock]

For the records: https://github.com/LMMS/lmms/blob/old-master/src/gui/cusis_style.cpp

[Sti2nd]

I would like the switch to be available too, I mean... Why not? :p

[pgiblock]

At this point... so much stuff was added to the new theme, that I think some of these elements should just be merged into the current living theme. Give me a few days on this one.. I'd like to at least integrate the "pattern elements" as seen in the song editor. The style-switching was sort of a hack anyway, and we don't have a convincing alternative to switch to at this point.

[Sti2nd]

Aww, with the current theme this would have been perfect.

[diizy]

On 03/12/2014 09:53 PM, Stian Jørgensrud wrote:

Aww, with the current theme this would have been perfect.

We now have semi-stylable (colour can be chosen in CSS) pattern graphics
with lots of improvements (highlights, etc.), so I wouldn't replace all
of that with legacy code, unless that code had all the features that
have been implemented recently in the current patternviews, or could be
integrated with the current code.

[tresf]

Marking as duplicate of the "Cusis Theme" effort #1839 and closing to consolidate bug reports.