Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change shortcut keys in Piano Roll and Song Editor #1338

Closed
Sti2nd opened this issue Nov 22, 2014 · 5 comments
Closed

Change shortcut keys in Piano Roll and Song Editor #1338

Sti2nd opened this issue Nov 22, 2014 · 5 comments

Comments

@Sti2nd
Copy link
Contributor

Sti2nd commented Nov 22, 2014

Ctrl is the key for absolutely everything in the Song Editor (duplicate, fine adjustments, drag controllers, clone tracks), which can be wise as it is simple to remember, though it could also be smart to group the shortcuts. What do connecting controllers and duplicating segments have in common? Connecting controllers and cloning tracks could be one type, and duplicating, resizing and moving segments could be another type.
The Piano Roll uses Shift for duplicate/clone and Alt for fine adjustments, so it seems like the Piano Roll is inconsistent with itself and the rest of the program and should be changed, but if we imagine that Ctrl would be the key for "track and controller"- type of actions, Shift is a likely key to use for duplication and fine adjustments. This would however require the change of quite a few shortcut keys.
Also I discovered that you cannot have the same key for fine adjustment and quick resize in Piano Roll as they should work together.

Alternative 1 (Fine adjustments on Ctrl)

  1. Change Duplication in Song Editor to Shift
  2. Change Quick-select in Piano Roll to Alt
  3. Change override quantization (fine adjustment) in Piano Roll to Ctrl
    Future. Add the override quantization function to automation editor and possibly Song Editor :) Add quick select function to Song Editor and Possibly Automation Editor.

Alternative 2 (Fine adjustments on Shift)

  • As above only Shift will be Ctrl and Ctrl will be shift

Now this is the third revision, still can have missed out some conflicting shortkeys so please comment

@Sti2nd
Copy link
Contributor Author

Sti2nd commented Nov 22, 2014

@lukas-w Changed subject entirely

@Sti2nd Sti2nd changed the title Holding down Alt would override the quantization in automation Editor Change shortcut keys in Piano Roll and Song Editor Nov 22, 2014
@tresf
Copy link
Member

tresf commented Nov 22, 2014

There is no question that our editors need some usability improvements and consistency fixes.

Possibly related:
#621 #822 #942 #741 #1122 #1144

In terms of consistency with shortcut keys, we should make a small table (reference guide) and agree on what the functionality should be. When someone finds a part of the interface in violation of that reference guide, we file a bug, reference the table and fix it.

In terms of usability improvements, those are generally more involved, but we could probably make a simple matrix too, but instead of the shortcut key, we'd have a checkbox that represents if it has been implemented yet.

Then we can make a milestone objective to fix these things and the newcomers looking for work could start right in on the usability stuff, since it tends to be a good primer into our codebase.

-Tres

@Sti2nd
Copy link
Contributor Author

Sti2nd commented Nov 22, 2014

Table over how it is now, or a future table?

@tresf
Copy link
Member

tresf commented Nov 22, 2014

Table over how it is now, or a future table?

Future.

@Sti2nd
Copy link
Contributor Author

Sti2nd commented Dec 23, 2014

/tag duplicate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants